You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "dajac (via GitHub)" <gi...@apache.org> on 2024/08/20 14:46:06 UTC

[PR] KAFKA-16736; Remove `offsets.commit.required.acks` in 4.0 [kafka]

dajac opened a new pull request, #16938:
URL: https://github.com/apache/kafka/pull/16938

   This patch removes the deprecated `offsets.commit.required.acks` config for the 4.0 release.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-16736; Remove `offsets.commit.required.acks` in 4.0 [kafka]

Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #16938:
URL: https://github.com/apache/kafka/pull/16938#issuecomment-2299083863

   There are some compilation errors. I will fix them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-16736; Remove `offsets.commit.required.acks` in 4.0 [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #16938:
URL: https://github.com/apache/kafka/pull/16938


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-16736; Remove `offsets.commit.required.acks` in 4.0 [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16938:
URL: https://github.com/apache/kafka/pull/16938#issuecomment-2300429740

   > in tests/kafkatest/services/kafka/config_property.py
   
   I had noticed too. IMHO, we should add `KafkaConfig` reference instead of copy. That is easy to be out-of-date


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-16736; Remove `offsets.commit.required.acks` in 4.0 [kafka]

Posted by "jeffkbkim (via GitHub)" <gi...@apache.org>.
jeffkbkim commented on PR #16938:
URL: https://github.com/apache/kafka/pull/16938#issuecomment-2300414495

   I see 
   ```
   val OffsetCommitRequiredAcksProp = "offsets.commit.required.acks"
   ```
   in tests/kafkatest/services/kafka/config_property.py


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-16736; Remove `offsets.commit.required.acks` in 4.0 [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16938:
URL: https://github.com/apache/kafka/pull/16938#issuecomment-2300473107

   > in tests/kafkatest/services/kafka/config_property.py
   
   https://issues.apache.org/jira/browse/KAFKA-17382 I open a jira to cleanup the configs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org