[GitHub] [pinot] amrishlal commented on a change in pull request #7568: EXPLAIN PLAN

[GitBox <gi...@apache.org>]

amrishlal commented on a change in pull request #7568:
URL: https://github.com/apache/pinot/pull/7568#discussion_r759887289



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/common/Operator.java
##########
@@ -46,6 +47,12 @@
    */
   String getOperatorName();
 
+  /** @return List of {@link Operator}s that this operator depends upon. */
+  List<Operator> getChildOperators();
+
+  /** @return Description of this operator for Explain Plan */
+  String toExplainString();

Review comment:
       Done

##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/filter/predicate/PredicateEvaluatorProvider.java
##########
@@ -37,47 +37,65 @@ private PredicateEvaluatorProvider() {
 
   public static PredicateEvaluator getPredicateEvaluator(Predicate predicate, @Nullable Dictionary dictionary,
       DataType dataType) {
+    PredicateEvaluator predicateEvaluator;

Review comment:
       Fixed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org