You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@abdera.apache.org by "Sergio Bossa (JIRA)" <ji...@apache.org> on 2008/07/08 17:36:32 UTC

[jira] Created: (ABDERA-188) OpenSearch support improvement

OpenSearch support improvement
------------------------------

                 Key: ABDERA-188
                 URL: https://issues.apache.org/jira/browse/ABDERA-188
             Project: Abdera
          Issue Type: Improvement
    Affects Versions: 0.5.0
            Reporter: Sergio Bossa


I've improved Open Search support by almost completely rewriting the current Open Search extension and providing a new implementation with the following features which should cover all Open Search use cases:

* Abdera model elements for both the Atom extension and the Open Search Description document (package org.apache.abdera.ext.opensearch.model).
* Metadata (*Info) classes for representing the Open Search server model (package org.apache.abdera.ext.opensearch.server).
* Adapter interface to implement for actually handling search urls (package org.apache.abdera.ext.opensearch.server).
* Two new target types (package org.apache.abdera.ext.opensearch.server.processors).
* Two new request processors for handling requests to the Open Search description document and the Open Search urls (package org.apache.abdera.ext.opensearch.server.processors).

I'm going to attach a patch file with the new implementation and related tests.

I'd like to have your opinion about the whole stuff. 


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Request for Abdera information on Geronimo

Posted by "Jamkhedkar, Prashant" <pj...@paypal.com>.
 
Hi,

I want to deploy Abdera on Geronimo, I wanted to request if 
anyone had pointers to do the deployment, details about configuration
On Geronimo, etc ?

Appreciate your time,

Thanks,
Prashant

[jira] Commented: (ABDERA-188) OpenSearch support improvement

Posted by "Sergio Bossa (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ABDERA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614093#action_12614093 ] 

Sergio Bossa commented on ABDERA-188:
-------------------------------------

I'm working at enhancing my implementation.
I'll submit the new patch tomorrow.

> OpenSearch support improvement
> ------------------------------
>
>                 Key: ABDERA-188
>                 URL: https://issues.apache.org/jira/browse/ABDERA-188
>             Project: Abdera
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Sergio Bossa
>         Attachments: OpenSearch.diff, opensearch.zip
>
>
> I've improved Open Search support by almost completely rewriting the current Open Search extension and providing a new implementation with the following features which should cover all Open Search use cases:
> * Abdera model elements for both the Atom extension and the Open Search Description document (package org.apache.abdera.ext.opensearch.model).
> * Metadata (*Info) classes for representing the Open Search server model (package org.apache.abdera.ext.opensearch.server).
> * Adapter interface to implement for actually handling search urls (package org.apache.abdera.ext.opensearch.server).
> * Two new target types (package org.apache.abdera.ext.opensearch.server.processors).
> * Two new request processors for handling requests to the Open Search description document and the Open Search urls (package org.apache.abdera.ext.opensearch.server.processors).
> I'm going to attach a patch file with the new implementation and related tests.
> I'd like to have your opinion about the whole stuff. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (ABDERA-188) OpenSearch support improvement

Posted by "David Calavera (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ABDERA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Calavera resolved ABDERA-188.
-----------------------------------

    Resolution: Fixed
      Assignee: David Calavera

> OpenSearch support improvement
> ------------------------------
>
>                 Key: ABDERA-188
>                 URL: https://issues.apache.org/jira/browse/ABDERA-188
>             Project: Abdera
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Sergio Bossa
>            Assignee: David Calavera
>         Attachments: OpenSearch.diff, opensearch.zip, OpenSearchV2.diff, opensearchV2.zip, OpenSearchV3.diff
>
>
> I've improved Open Search support by almost completely rewriting the current Open Search extension and providing a new implementation with the following features which should cover all Open Search use cases:
> * Abdera model elements for both the Atom extension and the Open Search Description document (package org.apache.abdera.ext.opensearch.model).
> * Metadata (*Info) classes for representing the Open Search server model (package org.apache.abdera.ext.opensearch.server).
> * Adapter interface to implement for actually handling search urls (package org.apache.abdera.ext.opensearch.server).
> * Two new target types (package org.apache.abdera.ext.opensearch.server.processors).
> * Two new request processors for handling requests to the Open Search description document and the Open Search urls (package org.apache.abdera.ext.opensearch.server.processors).
> I'm going to attach a patch file with the new implementation and related tests.
> I'd like to have your opinion about the whole stuff. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ABDERA-188) OpenSearch support improvement

Posted by "Sergio Bossa (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ABDERA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sergio Bossa updated ABDERA-188:
--------------------------------

    Attachment: opensearch.zip

David,

I'm attaching all sources in a zip file: just put them into the opensearch extension directory.
Thanks for your interest!

> OpenSearch support improvement
> ------------------------------
>
>                 Key: ABDERA-188
>                 URL: https://issues.apache.org/jira/browse/ABDERA-188
>             Project: Abdera
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Sergio Bossa
>         Attachments: OpenSearch.diff, opensearch.zip
>
>
> I've improved Open Search support by almost completely rewriting the current Open Search extension and providing a new implementation with the following features which should cover all Open Search use cases:
> * Abdera model elements for both the Atom extension and the Open Search Description document (package org.apache.abdera.ext.opensearch.model).
> * Metadata (*Info) classes for representing the Open Search server model (package org.apache.abdera.ext.opensearch.server).
> * Adapter interface to implement for actually handling search urls (package org.apache.abdera.ext.opensearch.server).
> * Two new target types (package org.apache.abdera.ext.opensearch.server.processors).
> * Two new request processors for handling requests to the Open Search description document and the Open Search urls (package org.apache.abdera.ext.opensearch.server.processors).
> I'm going to attach a patch file with the new implementation and related tests.
> I'd like to have your opinion about the whole stuff. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ABDERA-188) OpenSearch support improvement

Posted by "Sergio Bossa (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ABDERA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sergio Bossa updated ABDERA-188:
--------------------------------

    Attachment: OpenSearchV2.diff

Here is the updated version of my Open Search implementation.
Thanks!

> OpenSearch support improvement
> ------------------------------
>
>                 Key: ABDERA-188
>                 URL: https://issues.apache.org/jira/browse/ABDERA-188
>             Project: Abdera
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Sergio Bossa
>         Attachments: OpenSearch.diff, opensearch.zip, OpenSearchV2.diff
>
>
> I've improved Open Search support by almost completely rewriting the current Open Search extension and providing a new implementation with the following features which should cover all Open Search use cases:
> * Abdera model elements for both the Atom extension and the Open Search Description document (package org.apache.abdera.ext.opensearch.model).
> * Metadata (*Info) classes for representing the Open Search server model (package org.apache.abdera.ext.opensearch.server).
> * Adapter interface to implement for actually handling search urls (package org.apache.abdera.ext.opensearch.server).
> * Two new target types (package org.apache.abdera.ext.opensearch.server.processors).
> * Two new request processors for handling requests to the Open Search description document and the Open Search urls (package org.apache.abdera.ext.opensearch.server.processors).
> I'm going to attach a patch file with the new implementation and related tests.
> I'd like to have your opinion about the whole stuff. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ABDERA-188) OpenSearch support improvement

Posted by "David Calavera (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ABDERA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614096#action_12614096 ] 

David Calavera commented on ABDERA-188:
---------------------------------------

Great, thanks Sergio, please upload it as a diff file. I'm going to take a look this weekend

> OpenSearch support improvement
> ------------------------------
>
>                 Key: ABDERA-188
>                 URL: https://issues.apache.org/jira/browse/ABDERA-188
>             Project: Abdera
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Sergio Bossa
>         Attachments: OpenSearch.diff, opensearch.zip
>
>
> I've improved Open Search support by almost completely rewriting the current Open Search extension and providing a new implementation with the following features which should cover all Open Search use cases:
> * Abdera model elements for both the Atom extension and the Open Search Description document (package org.apache.abdera.ext.opensearch.model).
> * Metadata (*Info) classes for representing the Open Search server model (package org.apache.abdera.ext.opensearch.server).
> * Adapter interface to implement for actually handling search urls (package org.apache.abdera.ext.opensearch.server).
> * Two new target types (package org.apache.abdera.ext.opensearch.server.processors).
> * Two new request processors for handling requests to the Open Search description document and the Open Search urls (package org.apache.abdera.ext.opensearch.server.processors).
> I'm going to attach a patch file with the new implementation and related tests.
> I'd like to have your opinion about the whole stuff. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ABDERA-188) OpenSearch support improvement

Posted by "Sergio Bossa (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ABDERA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614822#action_12614822 ] 

Sergio Bossa commented on ABDERA-188:
-------------------------------------

Just two words about how to configure the Open Search support into the current Abdera infrastructure.
It's very simple, indeed.

First of all, you have to configure all data related to your Open Search service into the *Info classes you can find into the org.apache.abdera.ext.opensearch.server and org.apache.abdera.ext.opensearch.server.impl packages.
You have to configure at least one OpenSearchInfo, with one or more OpenSearchUrlInfos and related OpenSearchUrlParameterInfo and OpenSearchUrlAdapter: see javadocs for more details.

Then, the OpenSearchInfo must be set into the two new request processors: org.apache.abdera.ext.opensearch.server.processors.OpenSearchDescriptionRequestProcessor and org.apache.abdera.ext.opensearch.server.processors.OpenSearchUrlRequestProcessor.

Finally, the two processors must be registered into the proper TargetResolver with their related target types you can find at: org.apache.abdera.ext.opensearch.server.processors.OpenSearchTargetTypes.

Moreover, remember that the actual search logic must be implemented into the OpenSearchUrlAdapter: you can extend the AbstractOpenSearchUrlAdapter convenience class, too.

That's all.
Let me know if you need any clarification.
Thanks!

> OpenSearch support improvement
> ------------------------------
>
>                 Key: ABDERA-188
>                 URL: https://issues.apache.org/jira/browse/ABDERA-188
>             Project: Abdera
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Sergio Bossa
>         Attachments: OpenSearch.diff, opensearch.zip, OpenSearchV2.diff, opensearchV2.zip, OpenSearchV3.diff
>
>
> I've improved Open Search support by almost completely rewriting the current Open Search extension and providing a new implementation with the following features which should cover all Open Search use cases:
> * Abdera model elements for both the Atom extension and the Open Search Description document (package org.apache.abdera.ext.opensearch.model).
> * Metadata (*Info) classes for representing the Open Search server model (package org.apache.abdera.ext.opensearch.server).
> * Adapter interface to implement for actually handling search urls (package org.apache.abdera.ext.opensearch.server).
> * Two new target types (package org.apache.abdera.ext.opensearch.server.processors).
> * Two new request processors for handling requests to the Open Search description document and the Open Search urls (package org.apache.abdera.ext.opensearch.server.processors).
> I'm going to attach a patch file with the new implementation and related tests.
> I'd like to have your opinion about the whole stuff. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ABDERA-188) OpenSearch support improvement

Posted by "Sergio Bossa (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ABDERA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614829#action_12614829 ] 

Sergio Bossa commented on ABDERA-188:
-------------------------------------

P.S.
The new processors must be added to the provider, too.

> OpenSearch support improvement
> ------------------------------
>
>                 Key: ABDERA-188
>                 URL: https://issues.apache.org/jira/browse/ABDERA-188
>             Project: Abdera
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Sergio Bossa
>         Attachments: OpenSearch.diff, opensearch.zip, OpenSearchV2.diff, opensearchV2.zip, OpenSearchV3.diff
>
>
> I've improved Open Search support by almost completely rewriting the current Open Search extension and providing a new implementation with the following features which should cover all Open Search use cases:
> * Abdera model elements for both the Atom extension and the Open Search Description document (package org.apache.abdera.ext.opensearch.model).
> * Metadata (*Info) classes for representing the Open Search server model (package org.apache.abdera.ext.opensearch.server).
> * Adapter interface to implement for actually handling search urls (package org.apache.abdera.ext.opensearch.server).
> * Two new target types (package org.apache.abdera.ext.opensearch.server.processors).
> * Two new request processors for handling requests to the Open Search description document and the Open Search urls (package org.apache.abdera.ext.opensearch.server.processors).
> I'm going to attach a patch file with the new implementation and related tests.
> I'd like to have your opinion about the whole stuff. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ABDERA-188) OpenSearch support improvement

Posted by "Sergio Bossa (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ABDERA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sergio Bossa updated ABDERA-188:
--------------------------------

    Attachment: OpenSearchV3.diff

David,

I see what you mean: here is a new diff file.
Let me know if it works now.
Thanks!

> OpenSearch support improvement
> ------------------------------
>
>                 Key: ABDERA-188
>                 URL: https://issues.apache.org/jira/browse/ABDERA-188
>             Project: Abdera
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Sergio Bossa
>         Attachments: OpenSearch.diff, opensearch.zip, OpenSearchV2.diff, opensearchV2.zip, OpenSearchV3.diff
>
>
> I've improved Open Search support by almost completely rewriting the current Open Search extension and providing a new implementation with the following features which should cover all Open Search use cases:
> * Abdera model elements for both the Atom extension and the Open Search Description document (package org.apache.abdera.ext.opensearch.model).
> * Metadata (*Info) classes for representing the Open Search server model (package org.apache.abdera.ext.opensearch.server).
> * Adapter interface to implement for actually handling search urls (package org.apache.abdera.ext.opensearch.server).
> * Two new target types (package org.apache.abdera.ext.opensearch.server.processors).
> * Two new request processors for handling requests to the Open Search description document and the Open Search urls (package org.apache.abdera.ext.opensearch.server.processors).
> I'm going to attach a patch file with the new implementation and related tests.
> I'd like to have your opinion about the whole stuff. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ABDERA-188) OpenSearch support improvement

Posted by "David Calavera (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ABDERA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614738#action_12614738 ] 

David Calavera commented on ABDERA-188:
---------------------------------------

You are in the right revision now, the last patch was create with the revision 676829, you can look at the file OpenSearchV2.diff:

--- src/test/resources/atomResponse.xml	(revision 676829)
+++ src/test/resources/atomResponse.xml	(working copy)

> OpenSearch support improvement
> ------------------------------
>
>                 Key: ABDERA-188
>                 URL: https://issues.apache.org/jira/browse/ABDERA-188
>             Project: Abdera
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Sergio Bossa
>         Attachments: OpenSearch.diff, opensearch.zip, OpenSearchV2.diff
>
>
> I've improved Open Search support by almost completely rewriting the current Open Search extension and providing a new implementation with the following features which should cover all Open Search use cases:
> * Abdera model elements for both the Atom extension and the Open Search Description document (package org.apache.abdera.ext.opensearch.model).
> * Metadata (*Info) classes for representing the Open Search server model (package org.apache.abdera.ext.opensearch.server).
> * Adapter interface to implement for actually handling search urls (package org.apache.abdera.ext.opensearch.server).
> * Two new target types (package org.apache.abdera.ext.opensearch.server.processors).
> * Two new request processors for handling requests to the Open Search description document and the Open Search urls (package org.apache.abdera.ext.opensearch.server.processors).
> I'm going to attach a patch file with the new implementation and related tests.
> I'd like to have your opinion about the whole stuff. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ABDERA-188) OpenSearch support improvement

Posted by "Sergio Bossa (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ABDERA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616485#action_12616485 ] 

Sergio Bossa commented on ABDERA-188:
-------------------------------------

Hi guys,
have you made any progress with this? Any chance to get this into trunk?
Thanks!

> OpenSearch support improvement
> ------------------------------
>
>                 Key: ABDERA-188
>                 URL: https://issues.apache.org/jira/browse/ABDERA-188
>             Project: Abdera
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Sergio Bossa
>         Attachments: OpenSearch.diff, opensearch.zip, OpenSearchV2.diff, opensearchV2.zip, OpenSearchV3.diff
>
>
> I've improved Open Search support by almost completely rewriting the current Open Search extension and providing a new implementation with the following features which should cover all Open Search use cases:
> * Abdera model elements for both the Atom extension and the Open Search Description document (package org.apache.abdera.ext.opensearch.model).
> * Metadata (*Info) classes for representing the Open Search server model (package org.apache.abdera.ext.opensearch.server).
> * Adapter interface to implement for actually handling search urls (package org.apache.abdera.ext.opensearch.server).
> * Two new target types (package org.apache.abdera.ext.opensearch.server.processors).
> * Two new request processors for handling requests to the Open Search description document and the Open Search urls (package org.apache.abdera.ext.opensearch.server.processors).
> I'm going to attach a patch file with the new implementation and related tests.
> I'd like to have your opinion about the whole stuff. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ABDERA-188) OpenSearch support improvement

Posted by "Sergio Bossa (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ABDERA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sergio Bossa updated ABDERA-188:
--------------------------------

    Attachment: opensearchV2.zip

David,

here is a zip archive containing the whole OpenSearch extension sources: I've excluded all ".svn" directories, so you should be able to easily replace all source files while keeping your svn wc data.
Let me know.
Thanks!

> OpenSearch support improvement
> ------------------------------
>
>                 Key: ABDERA-188
>                 URL: https://issues.apache.org/jira/browse/ABDERA-188
>             Project: Abdera
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Sergio Bossa
>         Attachments: OpenSearch.diff, opensearch.zip, OpenSearchV2.diff, opensearchV2.zip
>
>
> I've improved Open Search support by almost completely rewriting the current Open Search extension and providing a new implementation with the following features which should cover all Open Search use cases:
> * Abdera model elements for both the Atom extension and the Open Search Description document (package org.apache.abdera.ext.opensearch.model).
> * Metadata (*Info) classes for representing the Open Search server model (package org.apache.abdera.ext.opensearch.server).
> * Adapter interface to implement for actually handling search urls (package org.apache.abdera.ext.opensearch.server).
> * Two new target types (package org.apache.abdera.ext.opensearch.server.processors).
> * Two new request processors for handling requests to the Open Search description document and the Open Search urls (package org.apache.abdera.ext.opensearch.server.processors).
> I'm going to attach a patch file with the new implementation and related tests.
> I'd like to have your opinion about the whole stuff. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ABDERA-188) OpenSearch support improvement

Posted by "Sergio Bossa (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ABDERA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614987#action_12614987 ] 

Sergio Bossa commented on ABDERA-188:
-------------------------------------

Ok, I'll try to fix that diff problem and let you know.
In the meantime, given that my implementation is a drop-in replacement to the current one, may you try to completely replace current source files with the ones contained into the V3 zip file?
Thanks!

> OpenSearch support improvement
> ------------------------------
>
>                 Key: ABDERA-188
>                 URL: https://issues.apache.org/jira/browse/ABDERA-188
>             Project: Abdera
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Sergio Bossa
>         Attachments: OpenSearch.diff, opensearch.zip, OpenSearchV2.diff, opensearchV2.zip, OpenSearchV3.diff
>
>
> I've improved Open Search support by almost completely rewriting the current Open Search extension and providing a new implementation with the following features which should cover all Open Search use cases:
> * Abdera model elements for both the Atom extension and the Open Search Description document (package org.apache.abdera.ext.opensearch.model).
> * Metadata (*Info) classes for representing the Open Search server model (package org.apache.abdera.ext.opensearch.server).
> * Adapter interface to implement for actually handling search urls (package org.apache.abdera.ext.opensearch.server).
> * Two new target types (package org.apache.abdera.ext.opensearch.server.processors).
> * Two new request processors for handling requests to the Open Search description document and the Open Search urls (package org.apache.abdera.ext.opensearch.server.processors).
> I'm going to attach a patch file with the new implementation and related tests.
> I'd like to have your opinion about the whole stuff. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ABDERA-188) OpenSearch support improvement

Posted by "Sergio Bossa (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ABDERA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sergio Bossa updated ABDERA-188:
--------------------------------

    Attachment: OpenSearch.diff

Diff file starting from the SVN/trunk/extensions/opensearch directory.

> OpenSearch support improvement
> ------------------------------
>
>                 Key: ABDERA-188
>                 URL: https://issues.apache.org/jira/browse/ABDERA-188
>             Project: Abdera
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Sergio Bossa
>         Attachments: OpenSearch.diff
>
>
> I've improved Open Search support by almost completely rewriting the current Open Search extension and providing a new implementation with the following features which should cover all Open Search use cases:
> * Abdera model elements for both the Atom extension and the Open Search Description document (package org.apache.abdera.ext.opensearch.model).
> * Metadata (*Info) classes for representing the Open Search server model (package org.apache.abdera.ext.opensearch.server).
> * Adapter interface to implement for actually handling search urls (package org.apache.abdera.ext.opensearch.server).
> * Two new target types (package org.apache.abdera.ext.opensearch.server.processors).
> * Two new request processors for handling requests to the Open Search description document and the Open Search urls (package org.apache.abdera.ext.opensearch.server.processors).
> I'm going to attach a patch file with the new implementation and related tests.
> I'd like to have your opinion about the whole stuff. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ABDERA-188) OpenSearch support improvement

Posted by "David Primmer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ABDERA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614840#action_12614840 ] 

David Primmer commented on ABDERA-188:
--------------------------------------

Moves and are notoriously hard to do with patches and svn. 

I just tried to apply the v3 diff and there are still problems.

You have modify diffs for newly created resources:
one example is
Index: src/main/java/org/apache/abdera/ext/opensearch/model/IntegerElement.java

another baffler is
--- src/test/resources/atomResponse.xml	(revision 676829)
which I think david c complained about earlier.

You'll need to fix these things up. I suggest you verify that your patches work by applying them to a newly checked out wc before submitting them. You'll find these don't work. I suspect the problem is that your diffs do not span the proper revision range.

davep

> OpenSearch support improvement
> ------------------------------
>
>                 Key: ABDERA-188
>                 URL: https://issues.apache.org/jira/browse/ABDERA-188
>             Project: Abdera
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Sergio Bossa
>         Attachments: OpenSearch.diff, opensearch.zip, OpenSearchV2.diff, opensearchV2.zip, OpenSearchV3.diff
>
>
> I've improved Open Search support by almost completely rewriting the current Open Search extension and providing a new implementation with the following features which should cover all Open Search use cases:
> * Abdera model elements for both the Atom extension and the Open Search Description document (package org.apache.abdera.ext.opensearch.model).
> * Metadata (*Info) classes for representing the Open Search server model (package org.apache.abdera.ext.opensearch.server).
> * Adapter interface to implement for actually handling search urls (package org.apache.abdera.ext.opensearch.server).
> * Two new target types (package org.apache.abdera.ext.opensearch.server.processors).
> * Two new request processors for handling requests to the Open Search description document and the Open Search urls (package org.apache.abdera.ext.opensearch.server.processors).
> I'm going to attach a patch file with the new implementation and related tests.
> I'd like to have your opinion about the whole stuff. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ABDERA-188) OpenSearch support improvement

Posted by "Sergio Bossa (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ABDERA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615000#action_12615000 ] 

Sergio Bossa commented on ABDERA-188:
-------------------------------------

Sorry, previously I was referring to the V2 zip file.

> OpenSearch support improvement
> ------------------------------
>
>                 Key: ABDERA-188
>                 URL: https://issues.apache.org/jira/browse/ABDERA-188
>             Project: Abdera
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Sergio Bossa
>         Attachments: OpenSearch.diff, opensearch.zip, OpenSearchV2.diff, opensearchV2.zip, OpenSearchV3.diff
>
>
> I've improved Open Search support by almost completely rewriting the current Open Search extension and providing a new implementation with the following features which should cover all Open Search use cases:
> * Abdera model elements for both the Atom extension and the Open Search Description document (package org.apache.abdera.ext.opensearch.model).
> * Metadata (*Info) classes for representing the Open Search server model (package org.apache.abdera.ext.opensearch.server).
> * Adapter interface to implement for actually handling search urls (package org.apache.abdera.ext.opensearch.server).
> * Two new target types (package org.apache.abdera.ext.opensearch.server.processors).
> * Two new request processors for handling requests to the Open Search description document and the Open Search urls (package org.apache.abdera.ext.opensearch.server.processors).
> I'm going to attach a patch file with the new implementation and related tests.
> I'd like to have your opinion about the whole stuff. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ABDERA-188) OpenSearch support improvement

Posted by "Sergio Bossa (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ABDERA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615016#action_12615016 ] 

Sergio Bossa commented on ABDERA-188:
-------------------------------------

I've tried to fix the diff file, but it requires too much manual modifications, which I think are error-prone.
I think it's better to apply the diff as it is, skipping not found files, and then manually copy the following files from the V2 zip file:

src/test/resources/atomResponse.xml
src/main/java/org/apache/abdera/ext/opensearch/model/Query.java
src/main/java/org/apache/abdera/ext/opensearch/model/IntegerElement.java
src/main/java/org/apache/abdera/ext/opensearch/model/OpenSearchExtensionFactory.java

And finally delete:

src/main/java/org/apache/abdera/ext/opensearch/Query.java
src/main/java/org/apache/abdera/ext/opensearch/IntegerElement.java
src/main/java/org/apache/abdera/ext/opensearch/OpenSearchExtensionFactory.java

What do you think?

> OpenSearch support improvement
> ------------------------------
>
>                 Key: ABDERA-188
>                 URL: https://issues.apache.org/jira/browse/ABDERA-188
>             Project: Abdera
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Sergio Bossa
>         Attachments: OpenSearch.diff, opensearch.zip, OpenSearchV2.diff, opensearchV2.zip, OpenSearchV3.diff
>
>
> I've improved Open Search support by almost completely rewriting the current Open Search extension and providing a new implementation with the following features which should cover all Open Search use cases:
> * Abdera model elements for both the Atom extension and the Open Search Description document (package org.apache.abdera.ext.opensearch.model).
> * Metadata (*Info) classes for representing the Open Search server model (package org.apache.abdera.ext.opensearch.server).
> * Adapter interface to implement for actually handling search urls (package org.apache.abdera.ext.opensearch.server).
> * Two new target types (package org.apache.abdera.ext.opensearch.server.processors).
> * Two new request processors for handling requests to the Open Search description document and the Open Search urls (package org.apache.abdera.ext.opensearch.server.processors).
> I'm going to attach a patch file with the new implementation and related tests.
> I'd like to have your opinion about the whole stuff. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ABDERA-188) OpenSearch support improvement

Posted by "David Calavera (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ABDERA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614727#action_12614727 ] 

David Calavera commented on ABDERA-188:
---------------------------------------

Sergio please, update your abdera working copy and create the patch file again, the last diff is broken because your working copy is out of time. Thanks.

> OpenSearch support improvement
> ------------------------------
>
>                 Key: ABDERA-188
>                 URL: https://issues.apache.org/jira/browse/ABDERA-188
>             Project: Abdera
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Sergio Bossa
>         Attachments: OpenSearch.diff, opensearch.zip, OpenSearchV2.diff
>
>
> I've improved Open Search support by almost completely rewriting the current Open Search extension and providing a new implementation with the following features which should cover all Open Search use cases:
> * Abdera model elements for both the Atom extension and the Open Search Description document (package org.apache.abdera.ext.opensearch.model).
> * Metadata (*Info) classes for representing the Open Search server model (package org.apache.abdera.ext.opensearch.server).
> * Adapter interface to implement for actually handling search urls (package org.apache.abdera.ext.opensearch.server).
> * Two new target types (package org.apache.abdera.ext.opensearch.server.processors).
> * Two new request processors for handling requests to the Open Search description document and the Open Search urls (package org.apache.abdera.ext.opensearch.server.processors).
> I'm going to attach a patch file with the new implementation and related tests.
> I'd like to have your opinion about the whole stuff. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (ABDERA-188) OpenSearch support improvement

Posted by "David Calavera (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ABDERA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Calavera closed ABDERA-188.
---------------------------------


> OpenSearch support improvement
> ------------------------------
>
>                 Key: ABDERA-188
>                 URL: https://issues.apache.org/jira/browse/ABDERA-188
>             Project: Abdera
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Sergio Bossa
>            Assignee: David Calavera
>         Attachments: OpenSearch.diff, opensearch.zip, OpenSearchV2.diff, opensearchV2.zip, OpenSearchV3.diff
>
>
> I've improved Open Search support by almost completely rewriting the current Open Search extension and providing a new implementation with the following features which should cover all Open Search use cases:
> * Abdera model elements for both the Atom extension and the Open Search Description document (package org.apache.abdera.ext.opensearch.model).
> * Metadata (*Info) classes for representing the Open Search server model (package org.apache.abdera.ext.opensearch.server).
> * Adapter interface to implement for actually handling search urls (package org.apache.abdera.ext.opensearch.server).
> * Two new target types (package org.apache.abdera.ext.opensearch.server.processors).
> * Two new request processors for handling requests to the Open Search description document and the Open Search urls (package org.apache.abdera.ext.opensearch.server.processors).
> I'm going to attach a patch file with the new implementation and related tests.
> I'd like to have your opinion about the whole stuff. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ABDERA-188) OpenSearch support improvement

Posted by "Sergio Bossa (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ABDERA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614731#action_12614731 ] 

Sergio Bossa commented on ABDERA-188:
-------------------------------------

David,

I've just executed an "svn up" command against my Abdera wc trunk and everything is already updated: it prints "At revision 677907".
Any idea?

> OpenSearch support improvement
> ------------------------------
>
>                 Key: ABDERA-188
>                 URL: https://issues.apache.org/jira/browse/ABDERA-188
>             Project: Abdera
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Sergio Bossa
>         Attachments: OpenSearch.diff, opensearch.zip, OpenSearchV2.diff
>
>
> I've improved Open Search support by almost completely rewriting the current Open Search extension and providing a new implementation with the following features which should cover all Open Search use cases:
> * Abdera model elements for both the Atom extension and the Open Search Description document (package org.apache.abdera.ext.opensearch.model).
> * Metadata (*Info) classes for representing the Open Search server model (package org.apache.abdera.ext.opensearch.server).
> * Adapter interface to implement for actually handling search urls (package org.apache.abdera.ext.opensearch.server).
> * Two new target types (package org.apache.abdera.ext.opensearch.server.processors).
> * Two new request processors for handling requests to the Open Search description document and the Open Search urls (package org.apache.abdera.ext.opensearch.server.processors).
> I'm going to attach a patch file with the new implementation and related tests.
> I'd like to have your opinion about the whole stuff. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ABDERA-188) OpenSearch support improvement

Posted by "David Primmer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ABDERA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611706#action_12611706 ] 

David Primmer commented on ABDERA-188:
--------------------------------------

there are some problems with the diff in my attempts to apply it.
an example is 
--- src/main/java/org/apache/abdera/ext/opensearch/model/Query.java
this appears to be a move to a new folder and a modify and I couldn't get it to apply. maybe it's just me.

Haven't had a chance to look in detail yet, but in general, looks to be a great contribution.


> OpenSearch support improvement
> ------------------------------
>
>                 Key: ABDERA-188
>                 URL: https://issues.apache.org/jira/browse/ABDERA-188
>             Project: Abdera
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Sergio Bossa
>         Attachments: OpenSearch.diff
>
>
> I've improved Open Search support by almost completely rewriting the current Open Search extension and providing a new implementation with the following features which should cover all Open Search use cases:
> * Abdera model elements for both the Atom extension and the Open Search Description document (package org.apache.abdera.ext.opensearch.model).
> * Metadata (*Info) classes for representing the Open Search server model (package org.apache.abdera.ext.opensearch.server).
> * Adapter interface to implement for actually handling search urls (package org.apache.abdera.ext.opensearch.server).
> * Two new target types (package org.apache.abdera.ext.opensearch.server.processors).
> * Two new request processors for handling requests to the Open Search description document and the Open Search urls (package org.apache.abdera.ext.opensearch.server.processors).
> I'm going to attach a patch file with the new implementation and related tests.
> I'd like to have your opinion about the whole stuff. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.