You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/09/05 12:26:10 UTC

[GitHub] [dubbo-go-hessian2] cvictory opened a new pull request #225: Export some function

cvictory opened a new pull request #225:
URL: https://github.com/apache/dubbo-go-hessian2/pull/225


   As the title.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go-hessian2] AlexStocks merged pull request #225: Export some function

Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #225:
URL: https://github.com/apache/dubbo-go-hessian2/pull/225


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go-hessian2] AlexStocks commented on a change in pull request #225: Export some function

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #225:
URL: https://github.com/apache/dubbo-go-hessian2/pull/225#discussion_r483946450



##########
File path: null.go
##########
@@ -23,3 +23,8 @@ package hessian
 func encNull(b []byte) []byte {
 	return append(b, BC_NULL)
 }
+
+// It is the same as encNull. It is exported.

Review comment:
       直接把原函数改成大写不就得了吗?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go-hessian2] cvictory commented on a change in pull request #225: Export some function

Posted by GitBox <gi...@apache.org>.
cvictory commented on a change in pull request #225:
URL: https://github.com/apache/dubbo-go-hessian2/pull/225#discussion_r483947324



##########
File path: null.go
##########
@@ -23,3 +23,8 @@ package hessian
 func encNull(b []byte) []byte {
 	return append(b, BC_NULL)
 }
+
+// It is the same as encNull. It is exported.

Review comment:
       ok. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org