You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by woonsan <gi...@git.apache.org> on 2017/02/08 04:44:11 UTC
[GitHub] jmeter pull request #266: Migrating to SLF4J - components/visualizers packag...
GitHub user woonsan opened a pull request:
https://github.com/apache/jmeter/pull/266
Migrating to SLF4J - components/visualizers package
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woonsan/jmeter feature/bz60564-5
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/266.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #266
----
commit b65689334f40756d6a25edab0691e0cccdd32f0e
Author: Woonsan Ko <wo...@apache.org>
Date: 2017-02-08T04:36:45Z
Migrating to SLF4J - components/visualizers package
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request #266: Migrating to SLF4J - components/visualizers packag...
Posted by woonsan <gi...@git.apache.org>.
Github user woonsan commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/266#discussion_r100055502
--- Diff: src/components/org/apache/jmeter/visualizers/BSFListener.java ---
@@ -52,7 +52,7 @@ public void sampleOccurred(SampleEvent event) {
mgr.declareBean("sampleResult", result, SampleResult.class);
processFileOrScript(mgr);
} catch (BSFException e) {
- log.warn("Problem in BSF script "+e);
+ log.warn("Problem in BSF script. {}", e.toString());
--- End diff --
I wasn't able to determine which one is better myself without knowing the context. I left it with toString() for now, just assuming the original author thought stack trace was unnecessary.
By the way, I'd like to propose a new PR soon to have if condition for level checking in warn, info and debug level in case params invoking a method. I did that for debug level but want to extend the pattern in non-error level as well for better performance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request #266: Migrating to SLF4J - components/visualizers packag...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/266
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request #266: Migrating to SLF4J - components/visualizers packag...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/266#discussion_r100013972
--- Diff: src/components/org/apache/jmeter/visualizers/BSFListener.java ---
@@ -52,7 +52,7 @@ public void sampleOccurred(SampleEvent event) {
mgr.declareBean("sampleResult", result, SampleResult.class);
processFileOrScript(mgr);
} catch (BSFException e) {
- log.warn("Problem in BSF script "+e);
+ log.warn("Problem in BSF script. {}", e.toString());
--- End diff --
It's it preferable to use `log.warn("Problem in BSF script.", e);` here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---