You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Qian Xu <sx...@googlemail.com> on 2014/11/19 02:19:50 UTC
Review Request 28200: SQOOP-1754: Sqoop2: Remove JarUtil class
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28200/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1754
https://issues.apache.org/jira/browse/SQOOP-1754
Repository: sqoop-sqoop2
Description
-------
We're currently using JarUtil class to help us find location of various jars. The implementation is very buggy as it depends on jar name and default Class Loader. We already do have facility in ClassUtils that is able to get location of jar given class name and we should take advantage of that instead.
Diffs
-----
connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToInitializer.java f78786d
Diff: https://reviews.apache.org/r/28200/diff/
Testing
-------
Tested csv/avro/parquet jobs.
Thanks,
Qian Xu
Re: Review Request 28200: SQOOP-1754: Sqoop2: Remove JarUtil class
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On Nov. 19, 2014, 2:46 a.m., Abraham Elmahrek wrote:
> > This makes sense.
I'm having trouble applying the patch. Is it dependent on another patch?
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28200/#review62113
-----------------------------------------------------------
On Nov. 19, 2014, 1:19 a.m., Qian Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28200/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2014, 1:19 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1754
> https://issues.apache.org/jira/browse/SQOOP-1754
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> We're currently using JarUtil class to help us find location of various jars. The implementation is very buggy as it depends on jar name and default Class Loader. We already do have facility in ClassUtils that is able to get location of jar given class name and we should take advantage of that instead.
>
>
> Diffs
> -----
>
> connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToInitializer.java f78786d
>
> Diff: https://reviews.apache.org/r/28200/diff/
>
>
> Testing
> -------
>
> Tested csv/avro/parquet jobs.
>
>
> Thanks,
>
> Qian Xu
>
>
Re: Review Request 28200: SQOOP-1754: Sqoop2: Remove JarUtil class
Posted by Qian Xu <sx...@googlemail.com>.
> On Nov. 19, 2014, 10:46 a.m., Abraham Elmahrek wrote:
> > This makes sense.
>
> Abraham Elmahrek wrote:
> I'm having trouble applying the patch. Is it dependent on another patch?
Forgot to update code for SQOOP-1752 (a one line patch) first. I'll submit SQOOP-1754.2.patch to jira. Really sorry..
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28200/#review62113
-----------------------------------------------------------
On Nov. 19, 2014, 9:19 a.m., Qian Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28200/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2014, 9:19 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1754
> https://issues.apache.org/jira/browse/SQOOP-1754
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> We're currently using JarUtil class to help us find location of various jars. The implementation is very buggy as it depends on jar name and default Class Loader. We already do have facility in ClassUtils that is able to get location of jar given class name and we should take advantage of that instead.
>
>
> Diffs
> -----
>
> connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToInitializer.java f78786d
>
> Diff: https://reviews.apache.org/r/28200/diff/
>
>
> Testing
> -------
>
> Tested csv/avro/parquet jobs.
>
>
> Thanks,
>
> Qian Xu
>
>
Re: Review Request 28200: SQOOP-1754: Sqoop2: Remove JarUtil class
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28200/#review62113
-----------------------------------------------------------
Ship it!
This makes sense.
- Abraham Elmahrek
On Nov. 19, 2014, 1:19 a.m., Qian Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28200/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2014, 1:19 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1754
> https://issues.apache.org/jira/browse/SQOOP-1754
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> We're currently using JarUtil class to help us find location of various jars. The implementation is very buggy as it depends on jar name and default Class Loader. We already do have facility in ClassUtils that is able to get location of jar given class name and we should take advantage of that instead.
>
>
> Diffs
> -----
>
> connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToInitializer.java f78786d
>
> Diff: https://reviews.apache.org/r/28200/diff/
>
>
> Testing
> -------
>
> Tested csv/avro/parquet jobs.
>
>
> Thanks,
>
> Qian Xu
>
>