Re: [PR] Add E2E tests for DAG Runs page [airflow]

["vatsrahul1001 (via GitHub)" <gi...@apache.org>]

vatsrahul1001 commented on PR #59919:
URL: https://github.com/apache/airflow/pull/59919#issuecomment-3713306224

   > #59309
   
   @lin121291 Thanks for this PR! A few things:
   
   1. **WebKit timeout** - Add `test.setTimeout(60_000)` at describe level.
   
   2. **Ensure runs exist** - Add `beforeAll` to trigger a DAG:
      test.beforeAll(async ({ browser }) => {
        const context = await browser.newContext({ storageState: AUTH_FILE });
        const page = await context.newPage();
        const dagsPage = new DagsPage(page);
        await dagsPage.triggerDag(testConfig.testDag.id);
        await context.close();
      });
         This ensures runs exist for testing.
   
   3. **Remove fixed waits** - Replace `waitForTimeout(1000)` with element waits.
   
   4. **Error handling in navigate()** - Replace `.catch(() => {})` with proper assertions.
   5. Add tests for paginations
   
   Let me know if you have questions!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org