[GitHub] [lucene] dweiss commented on a diff in pull request #11990: Don't let merged passages push out lower-scoring ones

[GitBox <gi...@apache.org>]

dweiss commented on code in PR #11990:
URL: https://github.com/apache/lucene/pull/11990#discussion_r1036988933


##########
lucene/highlighter/src/java/org/apache/lucene/search/matchhighlight/PassageSelector.java:
##########
@@ -89,8 +89,9 @@ public List<Passage> pickBest(
     }
 
     // Best passages so far.
+    int pqSize = Math.max(markers.size(), maxPassages);

Review Comment:
   That sounds good to me as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org