You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by henryr <gi...@git.apache.org> on 2017/11/09 01:16:49 UTC

[GitHub] spark pull request #19701: [SPARK-22211][SQL][FOLLOWUP] Fix bad merge for te...

GitHub user henryr opened a pull request:

    https://github.com/apache/spark/pull/19701

    [SPARK-22211][SQL][FOLLOWUP] Fix bad merge for tests

    ## What changes were proposed in this pull request?
    
    The merge of SPARK-22211 to branch-2.2 dropped a couple of important lines that made sure the tests that compared plans did so with both plans having been analyzed. Fix by reintroducing the correct analysis statements.
    
    ## How was this patch tested?
    
    Re-ran LimitPushdownSuite. All tests passed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/henryr/spark branch-2.2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19701.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19701
    
----
commit 890f60895789234c96764b8ff917a7bc4faed93b
Author: Henry Robinson <he...@apache.org>
Date:   2017-11-09T01:12:13Z

    [SPARK-22211][SQL][FOLLOWUP] Fix bad merge for tests

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19701: [SPARK-22211][SQL][FOLLOWUP] Fix bad merge for tests

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19701
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19701: [SPARK-22211][SQL][FOLLOWUP] Fix bad merge for tests

Posted by dongjoon-hyun <gi...@git.apache.org>.

Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/19701
  
    The failure is not related to this.
    ```
    Traceback (most recent call last):
      File "/home/anaconda/lib/python2.7/runpy.py", line 162, in _run_module_as_main
        "__main__", fname, loader, pkg_name)
      File "/home/anaconda/lib/python2.7/runpy.py", line 72, in _run_code
        exec code in run_globals
      File "/home/jenkins/workspace/SparkPullRequestBuilder/python/pyspark/sql/tests.py", line 196, in <module>
        class SQLTests(ReusedPySparkTestCase):
      File "/home/jenkins/workspace/SparkPullRequestBuilder/python/pyspark/sql/tests.py", line 2200, in SQLTests
        @unittest.skipIf(not _have_pandas, "Pandas not installed")
    NameError: name '_have_pandas' is not defined
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19701: [SPARK-22211][SQL][FOLLOWUP] Fix bad merge for tests

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19701
  
    **[Test build #83615 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83615/testReport)** for PR 19701 at commit [`890f608`](https://github.com/apache/spark/commit/890f60895789234c96764b8ff917a7bc4faed93b).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19701: [SPARK-22211][SQL][FOLLOWUP] Fix bad merge for tests

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19701
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19701: [SPARK-22211][SQL][FOLLOWUP] Fix bad merge for tests

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19701
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83624/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19701: [SPARK-22211][SQL][FOLLOWUP] Fix bad merge for tests

Posted by gatorsmile <gi...@git.apache.org>.

Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/19701
  
    Retest this please.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19701: [SPARK-22211][SQL][FOLLOWUP] Fix bad merge for tests

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19701
  
    **[Test build #83615 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83615/testReport)** for PR 19701 at commit [`890f608`](https://github.com/apache/spark/commit/890f60895789234c96764b8ff917a7bc4faed93b).
     * This patch **fails PySpark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19701: [SPARK-22211][SQL][FOLLOWUP] Fix bad merge for tests

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19701
  
    **[Test build #83624 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83624/testReport)** for PR 19701 at commit [`890f608`](https://github.com/apache/spark/commit/890f60895789234c96764b8ff917a7bc4faed93b).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org