[GitHub] spark pull request #19399: [SPARK-22175][WEB-UI] Add status column to histor...

[ajbozarth <gi...@git.apache.org>]

Github user ajbozarth commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19399#discussion_r142232645
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
    @@ -850,6 +869,18 @@ private[history] class AppListingListener(log: FileStatus, clock: Clock) extends
             fileSize)
         }
     
    +    def applicationStatus : Option[String] = {
    +      if (startTime.getTime == -1) {
    +        Some("<Not Started>")
    +      } else if (endTime.getTime == -1) {
    +        Some("<In Progress>")
    +      } else if (jobToStatus.isEmpty || jobToStatus.exists(_._2 != "Succeeded")) {
    --- End diff --
    
    Similar to above, have you tested if/how much time this adds to a page load when a lot of Apps have a lot of Jobs?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org