[GitHub] [flink] dianfu commented on a change in pull request #9653: [FLINK-14014][python] Introduce PythonScalarFunctionRunner to handle the communication with Python worker for Python ScalarFunction execution

[GitBox <gi...@apache.org>]

dianfu commented on a change in pull request #9653: [FLINK-14014][python] Introduce PythonScalarFunctionRunner to handle the communication with Python worker for Python ScalarFunction execution
URL: https://github.com/apache/flink/pull/9653#discussion_r323147003
 
 

 ##########
 File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/python/PythonEnv.java
 ##########
 @@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.functions.python;
+
+import org.apache.flink.util.Preconditions;
+
+import java.io.Serializable;
+
+/**
+ * Python execution environments.
+ */
+public final class PythonEnv implements Serializable {
+
+	private static final long serialVersionUID = 1L;
+
+	private final String pythonExec;
+
+	private final String pipExec;
+
+	private final String pythonWorkerCmd;
+
+	private final ExecType execType;
+
+	public PythonEnv(
+		String pythonExec,
+		String pipExec,
+		String pythonWorkerCmd,
+		ExecType execType) {
+		this.pythonExec = Preconditions.checkNotNull(pythonExec);
+		this.pipExec = Preconditions.checkNotNull(pipExec);
+		this.pythonWorkerCmd = Preconditions.checkNotNull(pythonWorkerCmd);
+		this.execType = Preconditions.checkNotNull(execType);
+	}
+
+	public String getPythonExec() {
+		return pythonExec;
+	}
+
+	public String getPipExec() {
+		return pipExec;
+	}
+
+	public String getPythonWorkerCmd() {
+		return pythonWorkerCmd;
+	}
+
+	public ExecType getExecType() {
+		return execType;
+	}
+
+	/**
+	 * The Execution type specifies how to execute the Python function.
+	 */
+	public enum ExecType {
+		// python function is executed in a separate process
+		PROCESS,
+
+		// python function is executed in a docker container
+		DOCKER,
+
+		// python function is executed in an external non-managed process
+		EXTERNAL,
+
+		UNKNOWN,
 
 Review comment:
   What about removing the UNKNOWN type?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services