You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/04/12 06:24:22 UTC
[GitHub] [superset] codecov[bot] commented on pull request #23656: chore(db_engine_specs): Refactor get_index
codecov[bot] commented on PR #23656:
URL: https://github.com/apache/superset/pull/23656#issuecomment-1504729459
## [Codecov](https://codecov.io/gh/apache/superset/pull/23656?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23656](https://codecov.io/gh/apache/superset/pull/23656?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e0a24a9) into [master](https://codecov.io/gh/apache/superset/commit/a5b6ccc1ec98cce297d5f8579c7704668fe698f3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5b6ccc) will **decrease** coverage by `11.35%`.
> The diff coverage is `75.00%`.
> :exclamation: Current head e0a24a9 differs from pull request most recent head d631e64. Consider uploading reports for the commit d631e64 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23656 +/- ##
===========================================
- Coverage 67.94% 56.60% -11.35%
===========================================
Files 1918 1918
Lines 73890 73896 +6
Branches 8058 8058
===========================================
- Hits 50204 41828 -8376
- Misses 21625 30007 +8382
Partials 2061 2061
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `53.18% <66.66%> (+0.01%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| python | `59.50% <75.00%> (-23.53%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `53.03% <75.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/23656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `76.10% <0.00%> (-13.44%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/23656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `76.46% <80.00%> (-14.41%)` | :arrow_down: |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/23656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `54.41% <80.00%> (-15.26%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/23656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `32.91% <100.00%> (-48.76%)` | :arrow_down: |
... and [298 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23656/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org