[GitHub] [incubator-yunikorn-core] kingamarton commented on a change in pull request #275: [YUNIKORN-582] Introduced soft/hard gang scheduling styles

[GitBox <gi...@apache.org>]

kingamarton commented on a change in pull request #275:
URL: https://github.com/apache/incubator-yunikorn-core/pull/275#discussion_r644614671



##########
File path: pkg/scheduler/objects/application.go
##########
@@ -97,6 +104,13 @@ func NewApplication(siApp *si.AddApplicationRequest, ugi security.UserGroup, eve
 	if time.Duration(0) == placeholderTimeout {
 		placeholderTimeout = defaultPlaceholderTimeout
 	}
+	gangSchedStyle := siApp.GetGangSchedulingStyle()
+	if gangSchedStyle != Soft && gangSchedStyle != Hard {
+		log.Logger().Info("Unknown gang scheduling style, using hard style as default",
+			zap.String("gang scheduling style", gangSchedStyle))
+		gangSchedStyle = Hard
+	}

Review comment:
       Since we are already using Hard by default in our 0.10 release, if we change it to Soft, can break some workflows, not? I used Hard as default, to keep the same behaviour as before.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org