You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2017/11/29 23:21:14 UTC

[GitHub] williaster opened a new pull request #3957: [time series table] visual improvements

williaster opened a new pull request #3957: [time series table] visual improvements
URL: https://github.com/apache/incubator-superset/pull/3957
 
 
   @graceguo-supercat @michellethomas 
   cc @mistercrunch 
   
   This PR adds several visual improvements to the time series table ? 
   
   - [improves positioning of tooltip](https://github.com/williaster/data-ui/pull/79) by updating to `@data-ui/sparkline@0.0.49`
   - adds partial tooltip opacity also [enabled by `@data-ui/sparkline@0.0.49`](https://github.com/williaster/data-ui/pull/79)
   - uses a more neutral #767676 for the sparkline color so it doesn't clash with the red/blue
   - adds ability to customize the format of the sparkline date 
   - removes grey background from table rows on hover
   - font size increased from `12px` to `14px`
   - color encoding is made more apparent and normalized for area through cell coloring (vs just the number)
   
   **Before**
   ![image](https://user-images.githubusercontent.com/4496521/33404234-698e4ad2-d518-11e7-9323-9ff02b63ba03.png)
   
   **After**
   ![image](https://user-images.githubusercontent.com/4496521/33404291-a368d88a-d518-11e7-8ac5-79d88854a800.png)
   
   **Gif**
   ![updated-timeseries-table](https://user-images.githubusercontent.com/4496521/33404159-1f317a4a-d518-11e7-9a9d-82576dc50b4e.gif)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services