You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/05 05:11:40 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #209: Use
-fno-common for sim KERNEL build
yamt opened a new pull request #209: Use -fno-common for sim KERNEL build
URL: https://github.com/apache/incubator-nuttx/pull/209
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #209:
Use -fno-common for sim KERNEL build
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #209: Use -fno-common for sim KERNEL build
URL: https://github.com/apache/incubator-nuttx/pull/209#discussion_r375087996
##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -63,6 +63,11 @@ ARCHINCLUDES = -I. -isystem $(TOPDIR)/include
ARCHINCLUDESXX = -I. -isystem $(TOPDIR)/include -isystem $(TOPDIR)/include/cxx
ARCHSCRIPT =
+ifneq ($(KERNEL),y)
+ ARCHCPUFLAGS += -fno-common
+ ARCHCPUFLAGSXX += -fno-common
+endif
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #209:
Use -fno-common for sim KERNEL build
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #209: Use -fno-common for sim KERNEL build
URL: https://github.com/apache/incubator-nuttx/pull/209#discussion_r375081375
##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -63,6 +63,11 @@ ARCHINCLUDES = -I. -isystem $(TOPDIR)/include
ARCHINCLUDESXX = -I. -isystem $(TOPDIR)/include -isystem $(TOPDIR)/include/cxx
ARCHSCRIPT =
+ifneq ($(KERNEL),y)
Review comment:
maybe a mistake. i'll check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #209:
Use -fno-common for sim KERNEL build
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #209: Use -fno-common for sim KERNEL build
URL: https://github.com/apache/incubator-nuttx/pull/209#discussion_r375081884
##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -63,6 +63,11 @@ ARCHINCLUDES = -I. -isystem $(TOPDIR)/include
ARCHINCLUDESXX = -I. -isystem $(TOPDIR)/include -isystem $(TOPDIR)/include/cxx
ARCHSCRIPT =
+ifneq ($(KERNEL),y)
+ ARCHCPUFLAGS += -fno-common
+ ARCHCPUFLAGSXX += -fno-common
+endif
Review comment:
probably.
the configs involving other make.defs don't build on macOS for unrelated reasons though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #209: Use
-fno-common for sim KERNEL build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #209: Use -fno-common for sim KERNEL build
URL: https://github.com/apache/incubator-nuttx/pull/209
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #209: Use -fno-common for sim KERNEL build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #209: Use -fno-common for sim KERNEL build
URL: https://github.com/apache/incubator-nuttx/pull/209#discussion_r375064507
##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -63,6 +63,11 @@ ARCHINCLUDES = -I. -isystem $(TOPDIR)/include
ARCHINCLUDESXX = -I. -isystem $(TOPDIR)/include -isystem $(TOPDIR)/include/cxx
ARCHSCRIPT =
+ifneq ($(KERNEL),y)
Review comment:
Why skip -fno-common for KERNEL build?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #209: Use -fno-common for sim KERNEL build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #209: Use -fno-common for sim KERNEL build
URL: https://github.com/apache/incubator-nuttx/pull/209#discussion_r375064674
##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -63,6 +63,11 @@ ARCHINCLUDES = -I. -isystem $(TOPDIR)/include
ARCHINCLUDESXX = -I. -isystem $(TOPDIR)/include -isystem $(TOPDIR)/include/cxx
ARCHSCRIPT =
+ifneq ($(KERNEL),y)
+ ARCHCPUFLAGS += -fno-common
+ ARCHCPUFLAGSXX += -fno-common
+endif
Review comment:
need add to other Mak.defs under boards/sim/sim/sim/configs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #209: Use -fno-common for sim KERNEL build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #209: Use -fno-common for sim KERNEL build
URL: https://github.com/apache/incubator-nuttx/pull/209#discussion_r375086349
##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -63,6 +63,11 @@ ARCHINCLUDES = -I. -isystem $(TOPDIR)/include
ARCHINCLUDESXX = -I. -isystem $(TOPDIR)/include -isystem $(TOPDIR)/include/cxx
ARCHSCRIPT =
+ifneq ($(KERNEL),y)
+ ARCHCPUFLAGS += -fno-common
+ ARCHCPUFLAGSXX += -fno-common
+endif
Review comment:
But other people may try to build that config, it's better to fix all together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #209:
Use -fno-common for sim KERNEL build
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #209: Use -fno-common for sim KERNEL build
URL: https://github.com/apache/incubator-nuttx/pull/209#discussion_r375090498
##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -63,6 +63,11 @@ ARCHINCLUDES = -I. -isystem $(TOPDIR)/include
ARCHINCLUDESXX = -I. -isystem $(TOPDIR)/include -isystem $(TOPDIR)/include/cxx
ARCHSCRIPT =
+ifneq ($(KERNEL),y)
Review comment:
i don't remember why i did the ifneq. i removed the conditional as it's necessary regardless of KERNEL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services