[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5008: assert: unify stack and register dump across platforms

[GitBox <gi...@apache.org>]

gustavonihei commented on a change in pull request #5008:
URL: https://github.com/apache/incubator-nuttx/pull/5008#discussion_r771567712



##########
File path: arch/xtensa/src/common/xtensa_dumpstate.c
##########
@@ -168,7 +168,7 @@ static inline void xtensa_registerdump(void)
 
 void xtensa_dumpstate(void)
 {
-  struct tcb_s *rtcb = running_task();
+  FAR struct tcb_s *rtcb = running_task();

Review comment:
       ```suggestion
     struct tcb_s *rtcb = running_task();
   ```
   The `FAR` qualifier had been wiped out from the `xtensa` and `risc-v` archs some time ago since it is mandatory only for common code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org