You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oodt.apache.org by Ricky Nguyen <ri...@gmail.com> on 2012/02/28 21:05:18 UTC
Review Request: OODT-361: Workflow test event fails with NPE
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4089/
-----------------------------------------------------------
Review request for oodt.
Summary
-------
When DateConvert.isoParse is given a null input, it throws NPE.
Solution is throw ParseException if input is null. WorkflowInstance catches ParseException and ignores it.
This addresses bug OODT-361.
https://issues.apache.org/jira/browse/OODT-361
Diffs
-----
trunk/commons/src/main/java/org/apache/oodt/commons/util/DateConvert.java 1294802
Diff: https://reviews.apache.org/r/4089/diff
Testing
-------
Ran HelloWorld, GoodbyeWorld.
Thanks,
Ricky
Re: Review Request: OODT-361: Workflow test event fails with NPE
Posted by Ricky Nguyen <ri...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4089/
-----------------------------------------------------------
(Updated 2012-02-29 19:20:28.973385)
Review request for oodt.
Changes
-------
updated exception msg
Summary
-------
When DateConvert.isoParse is given a null input, it throws NPE.
Solution is throw ParseException if input is null. WorkflowInstance catches ParseException and ignores it.
This addresses bug OODT-361.
https://issues.apache.org/jira/browse/OODT-361
Diffs (updated)
-----
trunk/commons/src/main/java/org/apache/oodt/commons/util/DateConvert.java 1295223
Diff: https://reviews.apache.org/r/4089/diff
Testing
-------
Ran HelloWorld, GoodbyeWorld.
Thanks,
Ricky
Re: Review Request: OODT-361: Workflow test event fails with NPE
Posted by Paul Ramirez <pr...@jpl.nasa.gov>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4089/#review5430
-----------------------------------------------------------
Ship it!
- Paul
On 2012-02-28 20:05:18, Ricky Nguyen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4089/
> -----------------------------------------------------------
>
> (Updated 2012-02-28 20:05:18)
>
>
> Review request for oodt.
>
>
> Summary
> -------
>
> When DateConvert.isoParse is given a null input, it throws NPE.
> Solution is throw ParseException if input is null. WorkflowInstance catches ParseException and ignores it.
>
>
> This addresses bug OODT-361.
> https://issues.apache.org/jira/browse/OODT-361
>
>
> Diffs
> -----
>
> trunk/commons/src/main/java/org/apache/oodt/commons/util/DateConvert.java 1294802
>
> Diff: https://reviews.apache.org/r/4089/diff
>
>
> Testing
> -------
>
> Ran HelloWorld, GoodbyeWorld.
>
>
> Thanks,
>
> Ricky
>
>
Re: Review Request: OODT-361: Workflow test event fails with NPE
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4089/#review5438
-----------------------------------------------------------
Ship it!
Minor comment, all looks well.
- Chris
On 2012-02-28 20:05:18, Ricky Nguyen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4089/
> -----------------------------------------------------------
>
> (Updated 2012-02-28 20:05:18)
>
>
> Review request for oodt.
>
>
> Summary
> -------
>
> When DateConvert.isoParse is given a null input, it throws NPE.
> Solution is throw ParseException if input is null. WorkflowInstance catches ParseException and ignores it.
>
>
> This addresses bug OODT-361.
> https://issues.apache.org/jira/browse/OODT-361
>
>
> Diffs
> -----
>
> trunk/commons/src/main/java/org/apache/oodt/commons/util/DateConvert.java 1294802
>
> Diff: https://reviews.apache.org/r/4089/diff
>
>
> Testing
> -------
>
> Ran HelloWorld, GoodbyeWorld.
>
>
> Thanks,
>
> Ricky
>
>
Re: Review Request: OODT-361: Workflow test event fails with NPE
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4089/#review5437
-----------------------------------------------------------
trunk/commons/src/main/java/org/apache/oodt/commons/util/DateConvert.java
<https://reviews.apache.org/r/4089/#comment11841>
might want to also add here "...24 characters in length or null." to the exception message.
- Chris
On 2012-02-28 20:05:18, Ricky Nguyen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4089/
> -----------------------------------------------------------
>
> (Updated 2012-02-28 20:05:18)
>
>
> Review request for oodt.
>
>
> Summary
> -------
>
> When DateConvert.isoParse is given a null input, it throws NPE.
> Solution is throw ParseException if input is null. WorkflowInstance catches ParseException and ignores it.
>
>
> This addresses bug OODT-361.
> https://issues.apache.org/jira/browse/OODT-361
>
>
> Diffs
> -----
>
> trunk/commons/src/main/java/org/apache/oodt/commons/util/DateConvert.java 1294802
>
> Diff: https://reviews.apache.org/r/4089/diff
>
>
> Testing
> -------
>
> Ran HelloWorld, GoodbyeWorld.
>
>
> Thanks,
>
> Ricky
>
>