You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/10/19 21:49:13 UTC
[GitHub] [hudi] nsivabalan opened a new pull request, #7006: [HUDI-5063] Enabling run time stats to be serialized with commit metadata
nsivabalan opened a new pull request, #7006:
URL: https://github.com/apache/hudi/pull/7006
### Change Logs
Recently we landed a patch where we reduced duplicate stats from commit metadata (https://github.com/apache/hudi/pull/6646/)
But looks like runtime stats were not serialized in json and hence those are missing from commit metadata for now. Fixing those in this patch.
### Impact
Fixed run time stats being populated in hudi commit metadata.
### Risk level (write none, low medium or high below)
low
### Documentation Update
N/A
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7006: [HUDI-5063] Enabling run time stats to be serialized with commit metadata
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7006:
URL: https://github.com/apache/hudi/pull/7006#issuecomment-1285002173
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "41131dab45357ef46c2f3a274da88feff085d97c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12358",
"triggerID" : "41131dab45357ef46c2f3a274da88feff085d97c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 41131dab45357ef46c2f3a274da88feff085d97c Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12358)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7006: [HUDI-5063] Enabling run time stats to be serialized with commit metadata
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7006:
URL: https://github.com/apache/hudi/pull/7006#issuecomment-1284652738
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "41131dab45357ef46c2f3a274da88feff085d97c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12358",
"triggerID" : "41131dab45357ef46c2f3a274da88feff085d97c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 41131dab45357ef46c2f3a274da88feff085d97c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12358)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7006: [HUDI-5063] Enabling run time stats to be serialized with commit metadata
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7006:
URL: https://github.com/apache/hudi/pull/7006#issuecomment-1284649059
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "41131dab45357ef46c2f3a274da88feff085d97c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "41131dab45357ef46c2f3a274da88feff085d97c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 41131dab45357ef46c2f3a274da88feff085d97c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua merged pull request #7006: [HUDI-5063] Enabling run time stats to be serialized with commit metadata
Posted by GitBox <gi...@apache.org>.
yihua merged PR #7006:
URL: https://github.com/apache/hudi/pull/7006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a diff in pull request #7006: [HUDI-5063] Enabling run time stats to be serialized with commit metadata
Posted by GitBox <gi...@apache.org>.
yihua commented on code in PR #7006:
URL: https://github.com/apache/hudi/pull/7006#discussion_r1002299508
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieWriteStat.java:
##########
@@ -163,7 +160,6 @@ public class HoodieWriteStat implements Serializable {
private Long maxEventTime;
@Nullable
- @JsonIgnore
Review Comment:
The only other class using `@JsonIgnore` is `HoodieConsistentHashingMetadata`, which looks legit.
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieWriteStat.java:
##########
@@ -163,7 +160,6 @@ public class HoodieWriteStat implements Serializable {
private Long maxEventTime;
@Nullable
- @JsonIgnore
Review Comment:
Have you checked if we use `@JsonIgnore` annotation elsewhere? We should avoid such a pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org