You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/08/16 08:48:39 UTC
[GitHub] [servicecomb-service-center] codecov-io commented on issue #572:
[SCB-1441] Support for tls certificates when using GRPC for data
synchronization
codecov-io commented on issue #572: [SCB-1441] Support for tls certificates when using GRPC for data synchronization
URL: https://github.com/apache/servicecomb-service-center/pull/572#issuecomment-521937135
# [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/572?src=pr&el=h1) Report
> Merging [#572](https://codecov.io/gh/apache/servicecomb-service-center/pull/572?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/606c91c7aacbaf64a8fc5ff5d4436bb120aac1f0?src=pr&el=desc) will **decrease** coverage by `0.42%`.
> The diff coverage is `8.41%`.
[](https://codecov.io/gh/apache/servicecomb-service-center/pull/572?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #572 +/- ##
=========================================
- Coverage 58.33% 57.9% -0.43%
=========================================
Files 201 202 +1
Lines 15452 15557 +105
=========================================
- Hits 9014 9009 -5
- Misses 5803 5908 +105
- Partials 635 640 +5
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/572?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [syncer/serf/config.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/572/diff?src=pr&el=tree#diff-c3luY2VyL3NlcmYvY29uZmlnLmdv) | `59.45% <100%> (+2.31%)` | :arrow_up: |
| [syncer/config/config.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/572/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy9jb25maWcuZ28=) | `55.55% <13.63%> (-29.3%)` | :arrow_down: |
| [syncer/config/tlsconfig.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/572/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy90bHNjb25maWcuZ28=) | `3.65% <3.65%> (ø)` | |
| [server/notify/listwatcher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/572/diff?src=pr&el=tree#diff-c2VydmVyL25vdGlmeS9saXN0d2F0Y2hlci5nbw==) | `69.44% <0%> (-9.73%)` | :arrow_down: |
| [server/service/util/tag\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/572/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC90YWdfdXRpbC5nbw==) | `61.53% <0%> (-3.85%)` | :arrow_down: |
| [pkg/util/tree.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/572/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `81.25% <0%> (-3.13%)` | :arrow_down: |
| [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/572/diff?src=pr&el=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `73.58% <0%> (-0.95%)` | :arrow_down: |
| [pkg/log/logrotate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/572/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `33.71% <0%> (-0.58%)` | :arrow_down: |
| [server/broker/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/572/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.2% <0%> (-0.27%)` | :arrow_down: |
| [server/plugin/pkg/registry/etcd/etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/572/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9ldGNkLmdv) | `86.3% <0%> (-0.19%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/572/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/572?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/572?src=pr&el=footer). Last update [606c91c...8d327db](https://codecov.io/gh/apache/servicecomb-service-center/pull/572?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services