[GitHub] rdblue commented on a change in pull request #85: Encryption APIs for Iceberg.

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #85: Encryption APIs for Iceberg.
URL: https://github.com/apache/incubator-iceberg/pull/85#discussion_r253150641
 
 

 ##########
 File path: api/src/main/java/com/netflix/iceberg/DataFile.java
 ##########
 @@ -127,6 +129,12 @@ static StructType getType(StructType partitionType) {
    */
   Map<Integer, ByteBuffer> upperBounds();
 
+  /**
+   * @return metadata about how this file is encrypted, or null if the file is stored in plain
+   *         text.
+   */
+  EncryptionKeyMetadata keyMetadata();
 
 Review comment:
   Why not return the ByteBuffer?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org