You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zjffdu <gi...@git.apache.org> on 2015/12/16 09:22:17 UTC
[GitHub] spark pull request: [SPARK-12361][PYSPARK][TESTS] Should set PYSPA...
GitHub user zjffdu opened a pull request:
https://github.com/apache/spark/pull/10322
[SPARK-12361][PYSPARK][TESTS] Should set PYSPARK_DRIVER_PYTHON before…
… python test
Although this patch still doesn't solve the issue why the return code is 0 (see jira description), it resolves the issue of python version mismatch.
@JoshRosen Could you help review it ? Thanks
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/spark SPARK-12361
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10322.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10322
----
commit c59e4a2f8017a59add6bcb18921424e1aa4b1040
Author: Jeff Zhang <zj...@apache.org>
Date: 2015-12-16T08:17:00Z
[SPARK-12361][PYSPARK][TESTS] Should set PYSPARK_DRIVER_PYTHON before python test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12361][PYSPARK][TESTS] Should set PYSPA...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10322#issuecomment-165039799
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12361][PYSPARK][TESTS] Should set PYSPA...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10322#issuecomment-165039624
**[Test build #47805 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47805/consoleFull)** for PR 10322 at commit [`c59e4a2`](https://github.com/apache/spark/commit/c59e4a2f8017a59add6bcb18921424e1aa4b1040).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12361][PYSPARK][TESTS] Should set PYSPA...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the pull request:
https://github.com/apache/spark/pull/10322#issuecomment-165036106
Yes, this issue only happens when I set PYSPARK_DRIVER_PYTHON in .profile.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12361][PYSPARK][TESTS] Should set PYSPA...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10322
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12361][PYSPARK][TESTS] Should set PYSPA...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/10322#issuecomment-165221194
LGTM, so I'm going to merge this into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12361][PYSPARK][TESTS] Should set PYSPA...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/10322#issuecomment-165034204
I guess this isn't a problem in Jenkins because we don't set `PYSPARK_DRIVER_PYTHON` there, so it defaults to the value of `PYSPARK_PYTHON`.
This seems fine to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12361][PYSPARK][TESTS] Should set PYSPA...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10322#issuecomment-165032906
**[Test build #47805 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47805/consoleFull)** for PR 10322 at commit [`c59e4a2`](https://github.com/apache/spark/commit/c59e4a2f8017a59add6bcb18921424e1aa4b1040).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12361][PYSPARK][TESTS] Should set PYSPA...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10322#issuecomment-165039800
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47805/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org