[jira] [Updated] (SOLR-14523) Enhance gradle logging calls validation: eliminate getMessage()

["Andras Salamon (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-14523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andras Salamon updated SOLR-14523:
----------------------------------
    Attachment: SOLR-14523.patch
        Status: Open  (was: Open)

I added {{logOk}} to suppress the warnings in {{HttpSolrCall}} because we call {{authResponse.getMessage()}} there. We could also put the message into a variable and use that in the log call if we want to avoid {{logOk}}.

In {{TestRerankBase}} the warning was in an unused method, so I just deleted the method.

> Enhance gradle logging calls validation: eliminate getMessage()
> ---------------------------------------------------------------
>
>                 Key: SOLR-14523
>                 URL: https://issues.apache.org/jira/browse/SOLR-14523
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Andras Salamon
>            Assignee: Erick Erickson
>            Priority: Minor
>         Attachments: SOLR-14523.patch, validation.patch
>
>
> SOLR-14280 fixed a logging problem in SolrConfig by removing a few getMessage() calls. We could enhance this solution by modifying gradle's logging calls validation and forbid getMessage() calls during logging. We should check the existing code and eliminate such calls.
> It is possible to suppress the warning using {{//logok}}.
> [~erickerickson] [~gerlowskija]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org