You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "haiyang1987 (via GitHub)" <gi...@apache.org> on 2023/06/18 01:51:46 UTC

[GitHub] [hadoop] haiyang1987 commented on a diff in pull request #5735: HDFS-17044. Process reported block toInvalidate logic should set the block size to NO_ACK

haiyang1987 commented on code in PR #5735:
URL: https://github.com/apache/hadoop/pull/5735#discussion_r1233173275


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java:
##########
@@ -3295,8 +3295,11 @@ private BlockInfo processReportedBlock(
     BlockInfo storedBlock = getStoredBlock(block);
     if(storedBlock == null) {
       // If blocksMap does not contain reported block id,
-      // the replica should be removed from the data-node.
-      toInvalidate.add(new Block(block));
+      // the replica should be removed from the data-node,

Review Comment:
   Sorry for the late reply.
   Noted, I will  update PR today, Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org