You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/10/16 03:22:21 UTC

[GitHub] [phoenix] ntshmah commented on a change in pull request #924: PHOENIX-6189 DATA_EXCEEDS_MAX_CAPACITY exception error string should …

ntshmah commented on a change in pull request #924:
URL: https://github.com/apache/phoenix/pull/924#discussion_r506022114



##########
File path: phoenix-core/src/test/java/org/apache/phoenix/schema/MutationTest.java
##########
@@ -92,18 +92,24 @@ public void testSizeConstraint() throws Exception {
                 fail();
             } catch (SQLException e) {
                 assertEquals(SQLExceptionCode.DATA_EXCEEDS_MAX_CAPACITY.getErrorCode(),e.getErrorCode());
+                assertFalse(e.getMessage().contains("abcd"));

Review comment:
       Nit: Could assign "abcd" to a string variable and use that here and on line 91.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org