[GitHub] [druid] liran-funaro commented on a change in pull request #10001: [Extension] oak-incremental-index: Low resource (RAM and CPU) incremental-index implementation using off-heap key/value map (OakMap)

[GitBox <gi...@apache.org>]

liran-funaro commented on a change in pull request #10001:
URL: https://github.com/apache/druid/pull/10001#discussion_r642934189



##########
File path: benchmarks/src/test/java/org/apache/druid/benchmark/FilteredAggregatorBenchmark.java
##########
@@ -106,6 +107,8 @@
 {
   static {
     NullHandling.initializeForTests();
+    // Register OakIncrementalIndex
+    IncrementalIndexCreator.JSON_MAPPER.registerModule(OakIncrementalIndexModule.JACKSON_MODULE);

Review comment:
       Actually, this works. I added oak-incremental-index as a dependency to the benchmark module.
   This is what I've seen other extensions have done.
   Check out line 186 in `benchmarks/pom.xml`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org