You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "github-code-scanning[bot] (via GitHub)" <gi...@apache.org> on 2023/02/02 06:54:06 UTC

[GitHub] [dolphinscheduler] github-code-scanning[bot] commented on a diff in pull request #13475: [Improvement-13472][Api] Removes the overhead of idle Quartz Threadpool of Api

github-code-scanning[bot] commented on code in PR #13475:
URL: https://github.com/apache/dolphinscheduler/pull/13475#discussion_r1094110735


##########
dolphinscheduler-scheduler-plugin/dolphinscheduler-scheduler-quartz/src/main/java/org/apache/dolphinscheduler/scheduler/quartz/QZeroSizeThreadPool.java:
##########
@@ -0,0 +1,16 @@
+package org.apache.dolphinscheduler.scheduler.quartz;
+
+import org.quartz.simpl.ZeroSizeThreadPool;
+
+/**
+ * fix spring bug : add getter、setter method for threadCount field
+ */
+public class QZeroSizeThreadPool extends ZeroSizeThreadPool {
+
+    public void setThreadCount(int count) {

Review Comment:
   ## Useless parameter
   
   The parameter 'count' is never used.
   
   [Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/2644)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org