You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/02 14:25:38 UTC
[GitHub] [airflow] vchiapaikeo opened a new pull request, #28677: Support partition_columns in BaseSQLToGCSOperator
vchiapaikeo opened a new pull request, #28677:
URL: https://github.com/apache/airflow/pull/28677
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #28677: Support partition_columns in BaseSQLToGCSOperator
Posted by GitBox <gi...@apache.org>.
eladkal commented on code in PR #28677:
URL: https://github.com/apache/airflow/pull/28677#discussion_r1064393076
##########
airflow/providers/google/cloud/transfers/sql_to_gcs.py:
##########
@@ -77,6 +78,10 @@ class BaseSQLToGCSOperator(BaseOperator):
account from the list granting this role to the originating account (templated).
:param upload_metadata: whether to upload the row count metadata as blob metadata
:param exclude_columns: set of columns to exclude from transmission
+ :param partition_columns: list of columns to use for file partitioning. In order to use
+ this parameter, you must sort your dataset by partition_columns. Do this by
+ passing an ORDER BY clause to the sql query. Files are uploaded to GCS as objects
+ with a hive style partitioning directory structure.
Review Comment:
```suggestion
with a hive style partitioning directory structure (templated).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #28677: Support partition_columns in BaseSQLToGCSOperator
Posted by GitBox <gi...@apache.org>.
eladkal merged PR #28677:
URL: https://github.com/apache/airflow/pull/28677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org