You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Peter Schuller (Created) (JIRA)" <ji...@apache.org> on 2012/02/10 19:01:00 UTC

[jira] [Created] (CASSANDRA-3887) NPE on start-up due to missing stage

NPE  on start-up due to missing stage
-------------------------------------

                 Key: CASSANDRA-3887
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3887
             Project: Cassandra
          Issue Type: Bug
            Reporter: Peter Schuller
            Priority: Minor


On 1.1 (with our patches, but fairly sure they aren't involved):

{code}
 INFO [main] 2012-02-10 17:57:26,220 StorageService.java (line 768) JOINING: waiting for ring and schema information

ERROR [Thread-6] 2012-02-10 17:57:26,333 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-6,5,main]
java.lang.NullPointerException
	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
ERROR [Thread-8] 2012-02-10 17:57:26,334 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-8,5,main]
java.lang.NullPointerException
	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
{code}

That NPE is after an assertion (not triggered due to lack of -ea). Race on start-up - getting messages before stages set up? (not investigating further right now)



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (CASSANDRA-3887) NPE on start-up due to missing stage

Posted by "Peter Schuller (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Schuller reassigned CASSANDRA-3887:
-----------------------------------------

    Assignee: Peter Schuller
    
> NPE  on start-up due to missing stage
> -------------------------------------
>
>                 Key: CASSANDRA-3887
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3887
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Peter Schuller
>            Assignee: Peter Schuller
>            Priority: Minor
>
> On 1.1 (with our patches, but fairly sure they aren't involved):
> {code}
>  INFO [main] 2012-02-10 17:57:26,220 StorageService.java (line 768) JOINING: waiting for ring and schema information
> ERROR [Thread-6] 2012-02-10 17:57:26,333 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-6,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> ERROR [Thread-8] 2012-02-10 17:57:26,334 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-8,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> {code}
> That NPE is after an assertion (not triggered due to lack of -ea). Race on start-up - getting messages before stages set up? (not investigating further right now)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3887) NPE on start-up due to missing stage

Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205779#comment-13205779 ] 

Jonathan Ellis commented on CASSANDRA-3887:
-------------------------------------------

What line is MS:564 in your build?  In current 1.1 it's the middle of logger.trace.
                
> NPE  on start-up due to missing stage
> -------------------------------------
>
>                 Key: CASSANDRA-3887
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3887
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Peter Schuller
>            Priority: Minor
>
> On 1.1 (with our patches, but fairly sure they aren't involved):
> {code}
>  INFO [main] 2012-02-10 17:57:26,220 StorageService.java (line 768) JOINING: waiting for ring and schema information
> ERROR [Thread-6] 2012-02-10 17:57:26,333 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-6,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> ERROR [Thread-8] 2012-02-10 17:57:26,334 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-8,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> {code}
> That NPE is after an assertion (not triggered due to lack of -ea). Race on start-up - getting messages before stages set up? (not investigating further right now)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3887) NPE on start-up due to missing stage

Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205840#comment-13205840 ] 

Jonathan Ellis commented on CASSANDRA-3887:
-------------------------------------------

I don't know how to make sense out of that, since we just asserted that stage != null on the previous line...
                
> NPE  on start-up due to missing stage
> -------------------------------------
>
>                 Key: CASSANDRA-3887
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3887
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Peter Schuller
>            Priority: Minor
>
> On 1.1 (with our patches, but fairly sure they aren't involved):
> {code}
>  INFO [main] 2012-02-10 17:57:26,220 StorageService.java (line 768) JOINING: waiting for ring and schema information
> ERROR [Thread-6] 2012-02-10 17:57:26,333 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-6,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> ERROR [Thread-8] 2012-02-10 17:57:26,334 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-8,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> {code}
> That NPE is after an assertion (not triggered due to lack of -ea). Race on start-up - getting messages before stages set up? (not investigating further right now)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3887) NPE on start-up due to missing stage

Posted by "Peter Schuller (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207358#comment-13207358 ] 

Peter Schuller commented on CASSANDRA-3887:
-------------------------------------------

So yeah, this seems like it might be a human (or possibly {{git rerere}}) merge boo-boo. The MIGRATION_REQUEST registration in StorageService had been dropped out. Sorry for wasting other people's time; this bug is not in upstream. Will close post-assertion commit.
                
> NPE  on start-up due to missing stage
> -------------------------------------
>
>                 Key: CASSANDRA-3887
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3887
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Peter Schuller
>            Assignee: Peter Schuller
>            Priority: Minor
>         Attachments: CASSANDRA-3887-improve-assert-1.1.txt
>
>
> On 1.1 (with our patches, but fairly sure they aren't involved):
> {code}
>  INFO [main] 2012-02-10 17:57:26,220 StorageService.java (line 768) JOINING: waiting for ring and schema information
> ERROR [Thread-6] 2012-02-10 17:57:26,333 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-6,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> ERROR [Thread-8] 2012-02-10 17:57:26,334 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-8,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> {code}
> That NPE is after an assertion (not triggered due to lack of -ea). Race on start-up - getting messages before stages set up? (not investigating further right now)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3887) NPE on start-up due to missing stage

Posted by "Peter Schuller (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205817#comment-13205817 ] 

Peter Schuller commented on CASSANDRA-3887:
-------------------------------------------

564 is the final line of receive():

{code}
    public void receive(Message message, String id)
    {
        if (logger_.isTraceEnabled())
            logger_.trace(FBUtilities.getBroadcastAddress() + " received " + message.getVerb()
                          + " from " + id + "@" + message.getFrom());

        message = SinkManager.processServerMessage(message, id);
        if (message == null)
            return;

        Runnable runnable = new MessageDeliveryTask(message, id);
        ExecutorService stage = StageManager.getStage(message.getMessageType());
        assert stage != null : "No stage for message type " + message.getMessageType();
        stage.execute(runnable);
    }
{code}

FYI, I'm including the diff of MessagingService.java in our branch relative to upstream 1.1 (not intended for inclusion, just FYI).

{code}
diff --git a/src/java/org/apache/cassandra/net/MessagingService.java b/src/java/org/apache/cassandra/net/MessagingService.java
index 3375b84..d7613cb 100644
--- a/src/java/org/apache/cassandra/net/MessagingService.java
+++ b/src/java/org/apache/cassandra/net/MessagingService.java
@@ -366,6 +366,14 @@ public final class MessagingService implements MessagingServiceMBean
         return Integer.toString(idGen.incrementAndGet());
     }
 
+    /*
+     * @see #sendRR(Message message, InetAddress to, IMessageCallback cb, long timeout)
+     */
+    public String sendRR(Message message, InetAddress to, IMessageCallback cb)
+    {
+        return sendRR(message, to, cb, DEFAULT_CALLBACK_TIMEOUT);
+    }
+
     /**
      * Send a message to a given endpoint. This method specifies a callback
      * which is invoked with the actual response.
@@ -376,11 +384,12 @@ public final class MessagingService implements MessagingServiceMBean
      * @param cb callback interface which is used to pass the responses or
      *           suggest that a timeout occurred to the invoker of the send().
      *           suggest that a timeout occurred to the invoker of the send().
+     * @param timeout the timeout used for expiration
      * @return an reference to message id used to match with the result
      */
-    public String sendRR(Message message, InetAddress to, IMessageCallback cb)
+    public String sendRR(Message message, InetAddress to, IMessageCallback cb, long timeout)
     {
-        String id = addCallback(cb, message, to, message.getMessageTimeout());
+        String id = addCallback(cb, message, to, timeout);
         sendOneWay(message, id, to);
         return id;
     }
{code}

                
> NPE  on start-up due to missing stage
> -------------------------------------
>
>                 Key: CASSANDRA-3887
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3887
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Peter Schuller
>            Priority: Minor
>
> On 1.1 (with our patches, but fairly sure they aren't involved):
> {code}
>  INFO [main] 2012-02-10 17:57:26,220 StorageService.java (line 768) JOINING: waiting for ring and schema information
> ERROR [Thread-6] 2012-02-10 17:57:26,333 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-6,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> ERROR [Thread-8] 2012-02-10 17:57:26,334 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-8,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> {code}
> That NPE is after an assertion (not triggered due to lack of -ea). Race on start-up - getting messages before stages set up? (not investigating further right now)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3887) NPE on start-up due to missing stage

Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205869#comment-13205869 ] 

Jonathan Ellis commented on CASSANDRA-3887:
-------------------------------------------

Ah, right.

Doesn't the StageManager static block mean that stages will be populated, at the latest, before the getStage method call?  Which would imply that we asked for a stage for a message type that doesn't have one, which is hard to diagnose w/o the assertion.
                
> NPE  on start-up due to missing stage
> -------------------------------------
>
>                 Key: CASSANDRA-3887
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3887
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Peter Schuller
>            Priority: Minor
>
> On 1.1 (with our patches, but fairly sure they aren't involved):
> {code}
>  INFO [main] 2012-02-10 17:57:26,220 StorageService.java (line 768) JOINING: waiting for ring and schema information
> ERROR [Thread-6] 2012-02-10 17:57:26,333 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-6,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> ERROR [Thread-8] 2012-02-10 17:57:26,334 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-8,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> {code}
> That NPE is after an assertion (not triggered due to lack of -ea). Race on start-up - getting messages before stages set up? (not investigating further right now)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3887) NPE on start-up due to missing stage

Posted by "Peter Schuller (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207311#comment-13207311 ] 

Peter Schuller commented on CASSANDRA-3887:
-------------------------------------------

{code}
java.lang.AssertionError: No stage for message type null
        at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:563)
        at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
        at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
{code}

I'm beginning to suspect this is related to schema messages because I'm now having a node in a small 3 node cluster refusing to get the proper schema after I nuked data and re-bootstrapped with replace, and now seeing the same with a regular bootstrap (non-replace). Investigating.

                
> NPE  on start-up due to missing stage
> -------------------------------------
>
>                 Key: CASSANDRA-3887
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3887
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Peter Schuller
>            Assignee: Peter Schuller
>            Priority: Minor
>
> On 1.1 (with our patches, but fairly sure they aren't involved):
> {code}
>  INFO [main] 2012-02-10 17:57:26,220 StorageService.java (line 768) JOINING: waiting for ring and schema information
> ERROR [Thread-6] 2012-02-10 17:57:26,333 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-6,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> ERROR [Thread-8] 2012-02-10 17:57:26,334 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-8,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> {code}
> That NPE is after an assertion (not triggered due to lack of -ea). Race on start-up - getting messages before stages set up? (not investigating further right now)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-3887) NPE on start-up due to missing stage

Posted by "Peter Schuller (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Schuller updated CASSANDRA-3887:
--------------------------------------

    Attachment: CASSANDRA-3887-improve-assert-1.1.txt
    
> NPE  on start-up due to missing stage
> -------------------------------------
>
>                 Key: CASSANDRA-3887
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3887
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Peter Schuller
>            Assignee: Peter Schuller
>            Priority: Minor
>         Attachments: CASSANDRA-3887-improve-assert-1.1.txt
>
>
> On 1.1 (with our patches, but fairly sure they aren't involved):
> {code}
>  INFO [main] 2012-02-10 17:57:26,220 StorageService.java (line 768) JOINING: waiting for ring and schema information
> ERROR [Thread-6] 2012-02-10 17:57:26,333 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-6,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> ERROR [Thread-8] 2012-02-10 17:57:26,334 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-8,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> {code}
> That NPE is after an assertion (not triggered due to lack of -ea). Race on start-up - getting messages before stages set up? (not investigating further right now)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3887) NPE on start-up due to missing stage

Posted by "Peter Schuller (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207336#comment-13207336 ] 

Peter Schuller commented on CASSANDRA-3887:
-------------------------------------------

Yep. When I fixed the assertion to print the verb it becomes obvious:

{code}
java.lang.AssertionError: No stage for message type MIGRATION_REQUEST
        at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:563)
        at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
        at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
{code}

I'll submit a patch to fix the assertion and the hopefully the fix, assuming it's not something we have introduced in our branch locally.

                
> NPE  on start-up due to missing stage
> -------------------------------------
>
>                 Key: CASSANDRA-3887
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3887
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Peter Schuller
>            Assignee: Peter Schuller
>            Priority: Minor
>
> On 1.1 (with our patches, but fairly sure they aren't involved):
> {code}
>  INFO [main] 2012-02-10 17:57:26,220 StorageService.java (line 768) JOINING: waiting for ring and schema information
> ERROR [Thread-6] 2012-02-10 17:57:26,333 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-6,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> ERROR [Thread-8] 2012-02-10 17:57:26,334 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-8,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> {code}
> That NPE is after an assertion (not triggered due to lack of -ea). Race on start-up - getting messages before stages set up? (not investigating further right now)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3887) NPE on start-up due to missing stage

Posted by "Peter Schuller (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205847#comment-13205847 ] 

Peter Schuller commented on CASSANDRA-3887:
-------------------------------------------

Like I said that's due to lack of {{-ea}} on the JVM.
                
> NPE  on start-up due to missing stage
> -------------------------------------
>
>                 Key: CASSANDRA-3887
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3887
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Peter Schuller
>            Priority: Minor
>
> On 1.1 (with our patches, but fairly sure they aren't involved):
> {code}
>  INFO [main] 2012-02-10 17:57:26,220 StorageService.java (line 768) JOINING: waiting for ring and schema information
> ERROR [Thread-6] 2012-02-10 17:57:26,333 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-6,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> ERROR [Thread-8] 2012-02-10 17:57:26,334 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-8,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> {code}
> That NPE is after an assertion (not triggered due to lack of -ea). Race on start-up - getting messages before stages set up? (not investigating further right now)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (CASSANDRA-3887) NPE on start-up due to missing stage

Posted by "Peter Schuller (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Schuller resolved CASSANDRA-3887.
---------------------------------------

    Resolution: Invalid

assertion patch committed.
                
> NPE  on start-up due to missing stage
> -------------------------------------
>
>                 Key: CASSANDRA-3887
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3887
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Peter Schuller
>            Assignee: Peter Schuller
>            Priority: Minor
>         Attachments: CASSANDRA-3887-improve-assert-1.1.txt
>
>
> On 1.1 (with our patches, but fairly sure they aren't involved):
> {code}
>  INFO [main] 2012-02-10 17:57:26,220 StorageService.java (line 768) JOINING: waiting for ring and schema information
> ERROR [Thread-6] 2012-02-10 17:57:26,333 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-6,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> ERROR [Thread-8] 2012-02-10 17:57:26,334 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-8,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> {code}
> That NPE is after an assertion (not triggered due to lack of -ea). Race on start-up - getting messages before stages set up? (not investigating further right now)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3887) NPE on start-up due to missing stage

Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207346#comment-13207346 ] 

Jonathan Ellis commented on CASSANDRA-3887:
-------------------------------------------

+1 on the assertion patch
                
> NPE  on start-up due to missing stage
> -------------------------------------
>
>                 Key: CASSANDRA-3887
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3887
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Peter Schuller
>            Assignee: Peter Schuller
>            Priority: Minor
>         Attachments: CASSANDRA-3887-improve-assert-1.1.txt
>
>
> On 1.1 (with our patches, but fairly sure they aren't involved):
> {code}
>  INFO [main] 2012-02-10 17:57:26,220 StorageService.java (line 768) JOINING: waiting for ring and schema information
> ERROR [Thread-6] 2012-02-10 17:57:26,333 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-6,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> ERROR [Thread-8] 2012-02-10 17:57:26,334 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-8,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> {code}
> That NPE is after an assertion (not triggered due to lack of -ea). Race on start-up - getting messages before stages set up? (not investigating further right now)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3887) NPE on start-up due to missing stage

Posted by "Peter Schuller (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205586#comment-13205586 ] 

Peter Schuller commented on CASSANDRA-3887:
-------------------------------------------

Forgot to mention that this was on initial bootstrap into the cluster (but I don't know if that is incidental).
                
> NPE  on start-up due to missing stage
> -------------------------------------
>
>                 Key: CASSANDRA-3887
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3887
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Peter Schuller
>            Priority: Minor
>
> On 1.1 (with our patches, but fairly sure they aren't involved):
> {code}
>  INFO [main] 2012-02-10 17:57:26,220 StorageService.java (line 768) JOINING: waiting for ring and schema information
> ERROR [Thread-6] 2012-02-10 17:57:26,333 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-6,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> ERROR [Thread-8] 2012-02-10 17:57:26,334 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-8,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> {code}
> That NPE is after an assertion (not triggered due to lack of -ea). Race on start-up - getting messages before stages set up? (not investigating further right now)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3887) NPE on start-up due to missing stage

Posted by "Peter Schuller (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206736#comment-13206736 ] 

Peter Schuller commented on CASSANDRA-3887:
-------------------------------------------

You're right. I will have to try to re-produce again and investigate.
                
> NPE  on start-up due to missing stage
> -------------------------------------
>
>                 Key: CASSANDRA-3887
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3887
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Peter Schuller
>            Priority: Minor
>
> On 1.1 (with our patches, but fairly sure they aren't involved):
> {code}
>  INFO [main] 2012-02-10 17:57:26,220 StorageService.java (line 768) JOINING: waiting for ring and schema information
> ERROR [Thread-6] 2012-02-10 17:57:26,333 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-6,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> ERROR [Thread-8] 2012-02-10 17:57:26,334 AbstractCassandraDaemon.java (line 139) Fatal exception in thread Thread[Thread-8,5,main]
> java.lang.NullPointerException
> 	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:564)
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:160)
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:96)
> {code}
> That NPE is after an assertion (not triggered due to lack of -ea). Race on start-up - getting messages before stages set up? (not investigating further right now)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira