You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "maedhroz (via GitHub)" <gi...@apache.org> on 2023/01/30 20:49:05 UTC
[GitHub] [cassandra] maedhroz opened a new pull request, #2120: CASSANDRA-18195 Feature Flag for Accord Transactions
maedhroz opened a new pull request, #2120:
URL: https://github.com/apache/cassandra/pull/2120
patch by Caleb Rackliffe; reviewed by ? for CASSANDRA-18195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] dcapwell commented on a diff in pull request #2120: CASSANDRA-18195 Feature Flag for Accord Transactions
Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell commented on code in PR #2120:
URL: https://github.com/apache/cassandra/pull/2120#discussion_r1091280935
##########
src/java/org/apache/cassandra/service/accord/IAccordService.java:
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.service.accord;
+
+import accord.messages.Request;
+import accord.primitives.Txn;
+import accord.topology.TopologyManager;
+import org.apache.cassandra.db.ConsistencyLevel;
+import org.apache.cassandra.net.IVerbHandler;
+import org.apache.cassandra.service.accord.txn.TxnData;
+
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+
+public interface IAccordService
+{
+ IVerbHandler<? extends Request> verbHandler();
+
+ void createEpochFromConfigUnsafe();
+
+ TxnData coordinate(Txn txn, ConsistencyLevel consistencyLevel);
+
+ long currentEpoch();
+
+ void setCacheSize(long kb);
+
+ TopologyManager topology();
Review Comment:
I kinda wish we could just return `Node`, but since that is what owns the threads... I doubt we can =(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] maedhroz commented on pull request #2120: CASSANDRA-18195 Feature Flag for Accord Transactions
Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz commented on PR #2120:
URL: https://github.com/apache/cassandra/pull/2120#issuecomment-1409312472
https://app.circleci.com/pipelines/github/maedhroz/cassandra?branch=CASSANDRA-18195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] maedhroz commented on pull request #2120: CASSANDRA-18195 Feature Flag for Accord Transactions
Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz commented on PR #2120:
URL: https://github.com/apache/cassandra/pull/2120#issuecomment-1412634655
Committed as https://github.com/apache/cassandra/commit/2e680a33c03ce66d4b1358e1a1cc11cf4ee0189f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] maedhroz closed pull request #2120: CASSANDRA-18195 Feature Flag for Accord Transactions
Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz closed pull request #2120: CASSANDRA-18195 Feature Flag for Accord Transactions
URL: https://github.com/apache/cassandra/pull/2120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] maedhroz commented on a diff in pull request #2120: CASSANDRA-18195 Feature Flag for Accord Transactions
Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz commented on code in PR #2120:
URL: https://github.com/apache/cassandra/pull/2120#discussion_r1091365847
##########
test/conf/cassandra.yaml:
##########
@@ -53,6 +53,7 @@ materialized_views_enabled: true
drop_compact_storage_enabled: true
file_cache_enabled: true
auto_hints_cleanup_enabled: true
+accord_transactions_enabled: true
Review Comment:
I changed it in `AccordTestBase`, of course, but outside that, my goal was to keep the rest of the in-JVM test landscape running w/ the default, which right now means `accord_transactions_enabled: false`. Right trade-off, or am I thinking about it wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] dcapwell commented on a diff in pull request #2120: CASSANDRA-18195 Feature Flag for Accord Transactions
Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell commented on code in PR #2120:
URL: https://github.com/apache/cassandra/pull/2120#discussion_r1091281699
##########
test/conf/cassandra.yaml:
##########
@@ -53,6 +53,7 @@ materialized_views_enabled: true
drop_compact_storage_enabled: true
file_cache_enabled: true
auto_hints_cleanup_enabled: true
+accord_transactions_enabled: true
Review Comment:
don't you need to change this config for JVM dtest as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] maedhroz commented on a diff in pull request #2120: CASSANDRA-18195 Feature Flag for Accord Transactions
Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz commented on code in PR #2120:
URL: https://github.com/apache/cassandra/pull/2120#discussion_r1091423238
##########
test/conf/cassandra.yaml:
##########
@@ -53,6 +53,7 @@ materialized_views_enabled: true
drop_compact_storage_enabled: true
file_cache_enabled: true
auto_hints_cleanup_enabled: true
+accord_transactions_enabled: true
Review Comment:
You know what...I think you're right. It's probably better to have all of this active in a testing context so we ferret out problems earlier. Changing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] maedhroz commented on pull request #2120: CASSANDRA-18195 Feature Flag for Accord Transactions
Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz commented on PR #2120:
URL: https://github.com/apache/cassandra/pull/2120#issuecomment-1409708449
Fixed a couple test failures related to the simulator and LOCAL_SYSTEM_KEYSPACE_NAMES...tests running again...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] maedhroz commented on pull request #2120: CASSANDRA-18195 Feature Flag for Accord Transactions
Posted by "maedhroz (via GitHub)" <gi...@apache.org>.
maedhroz commented on PR #2120:
URL: https://github.com/apache/cassandra/pull/2120#issuecomment-1409315759
This patch adds a `cassandra.yaml` flag that, by default, prevents the following things from happening:
1.) At startup, prevents...
a.) ...Accord virtual tables from being created
b.) ...the Accord system keyspace/tables from being created
c.) ...the `AccordService` from being initialized, along w/ the threads it owns. (The implementation involving a no-op `IAccordService` might be up for discussion, but the idea seems to have been agreed to on the Jira already.)
2.) In general, prevents any CQL Accord transaction from executing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org