[GitHub] twill pull request #14: TWILL-138 Runtime log level change

[anew <gi...@git.apache.org>]

Github user anew commented on a diff in the pull request:

    https://github.com/apache/twill/pull/14#discussion_r90767209
  
    --- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java ---
    @@ -89,4 +90,45 @@
        * @return A {@link Future} that will be completed when the restart operation has been done.
        */
       Future<String> restartInstances(String runnable, int instanceId, int... moreInstanceIds);
    +
    +  /**
    +   * Set the log levels for requested logger names for Twill applications running in a container.
    +   * The log level for a logger name can be {@code null} except for the root logger, which will reset the log level for
    +   * the specified logger.
    +   *
    +   * @param logLevels The {@link Map} contains the requested logger names and log levels that need to be set.
    +   * @return A {@link Future} that will be completed when the set log level operation has been done. It will carry the
    +   *         {@link Map} of log levels as the result.
    +   */
    +  Future<Map<String, LogEntry.Level>> setLogLevels(Map<String, LogEntry.Level> logLevels);
    +
    +  /**
    +   * Set the log levels for requested logger names for a {@link TwillRunnable}.
    +   * The log level for a logger name can be {@code null} except for the root logger, which will reset the log level for
    +   * the specified logger.
    +   *
    +   * @param runnableName The name of the runnable to set the log level.
    +   * @param logLevelsForRunnable The {@link Map} contains the requested logger name and log level that
    +   *                             need to be changed.
    +   * @return A {@link Future} that will be completed when the set log level operation has been done. It will carry the
    +   *         {@link Map} of log levels as the result.
    +   */
    +  Future<Map<String, LogEntry.Level>> setLogLevels(String runnableName,
    +                                                   Map<String, LogEntry.Level> logLevelsForRunnable);
    +
    +  /**
    +   * Reset the log levels of all runnables to the default log level, {@code LogEntry.Level.INFO}.
    +   *
    +   * @return A {@link Future} that will be completed when the set log level operation has been done.
    +   */
    +  Future<String> resetLogLevels();
    +
    +  /**
    +   * Reset the log levels of the given runnable to the log levels when .
    --- End diff --
    
    this sentence is incomplete. Does this mean restore the log level to what it was before the last setLogLevel()? Or before setLogLevel was called for the first time? Or to what it was in the original spec?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---