You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "zxxwyt (via GitHub)" <gi...@apache.org> on 2026/10/04 04:55:12 UTC
Re: [PR] test: cover common utility boundary and recovery paths [incubator-seata]
zxxwyt commented on PR #8290:
URL: https://github.com/apache/incubator-seata/pull/8290#issuecomment-5976731263
@slievrly Thanks for checking. I verified the file-level Codecov reports: LowerCaseLinkHashMap increased from 50/61 fully covered lines (81.96%, with 8 misses and 3 partials) to 61/61 (100%). That gain of 11 was offset by a net loss of 18 in seven other files, resulting in the project-wide decrease. The reasons for those other coverage changes have not been established. [Base report](https://api.codecov.io/api/v2/github/apache/repos/incubator-seata/commits/f3eadb7c8f16618a215352504e08fa332909eed1/) / [PR report](https://api.codecov.io/api/v2/github/apache/repos/incubator-seata/commits/3606bd52d8376665cf211c1eda1e818d9046f78a/).
I have also added six UT cases in `8920a4f` for collection shrink/empty recovery, self-referencing map keys, unsupported duration units, malformed ISO8601 input, and numeric overflow with preserved exception causes.
Using the full common suite with separate `clean test` runs on JDK 17, against upstream `4d7ba2e`:
| Metric | Baseline | Updated PR |
| --- | --- | --- |
| Line coverage | 2347/2981 (78.73%) | 2364/2981 (79.30%) |
| Branch coverage | 955/1236 (77.27%) | 962/1236 (77.83%) |
All three target classes now have 100% line and branch coverage in that full-suite report. The updated suite runs 719 cases with zero failures/errors and four existing skips. The PR description includes the detailed measurements.
CI also confirms all 85 relevant cases pass on JDK 8 and 21, and the JDK 25 build passes. The full JDK 8 job currently fails in the unchanged `EtcdRegistryServiceImplMockTest.testUnsubscribe`, and JDK 21 fails in the unchanged `RaftRegistryServiceImplTest.watchHttp2ReuseForSameGroupTest`. The latest aggregate Codecov report is still pending. My rerun request was rejected because repository admin rights are required; could you rerun these two failed jobs? [JDK 8](https://github.com/apache/incubator-seata/actions/runs/37177618610/job/111363443652) / [JDK 21](https://github.com/apache/incubator-seata/actions/runs/37177618610/job/111363443676).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org