You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by radarwave <gi...@git.apache.org> on 2016/09/05 08:45:21 UTC
[GitHub] incubator-hawq pull request #888: HAWQ-904. Fix hawq config help messages.
GitHub user radarwave opened a pull request:
https://github.com/apache/incubator-hawq/pull/888
HAWQ-904. Fix hawq config help messages.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/radarwave/incubator-hawq confighelp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/888.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #888
----
commit cd2423947f74c1ab11f14e6b277870b22152b4d8
Author: rlei <rl...@pivotal.io>
Date: 2016-09-05T08:44:01Z
HAWQ-904. Fix hawq config help messages.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #888: HAWQ-904. Fix hawq config help messages.
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/888#discussion_r77566477
--- Diff: tools/bin/hawq ---
@@ -143,7 +143,7 @@ def main():
cmd = "%s; hawq_ctl %s %s" % (source_hawq_env, hawq_command, sub_args)
result = local_run(cmd)
elif hawq_command == "config":
- if second_arg in ['', 'help', '--help']:
+ if second_arg in ['', 'help', '--help', '-h']:
--- End diff --
Thanks, fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #888: HAWQ-904. Fix hawq config help messages.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hawq/pull/888
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #888: HAWQ-904. Fix hawq config help messages.
Posted by yaoj2 <gi...@git.apache.org>.
Github user yaoj2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/888
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #888: HAWQ-904. Fix hawq config help messages.
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/888#discussion_r77489007
--- Diff: tools/bin/hawq ---
@@ -143,7 +143,7 @@ def main():
cmd = "%s; hawq_ctl %s %s" % (source_hawq_env, hawq_command, sub_args)
result = local_run(cmd)
elif hawq_command == "config":
- if second_arg in ['', 'help', '--help']:
+ if second_arg in ['', 'help', '--help', '-h']:
--- End diff --
Also fix for "hawq activate"?
elif hawq_command == "activate":
if second_arg in ['', 'help', '--help']:
print ACTIVE_HELP
sys.exit(1)
cmd = "%s; hawq_ctl %s %s" % (source_hawq_env, hawq_command, sub_args)
result = local_run(cmd)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---