[GitHub] [thrift] kou opened a new pull request, #2726: THRIFT-5668: Install FindLibevent.cmake

[GitBox <gi...@apache.org>]

kou opened a new pull request, #2726:
URL: https://github.com/apache/thrift/pull/2726

   <!-- Explain the changes in the pull request below: -->
     
   Client: cpp
   
   ThriftConfig.cmake uses our FindLibevent.cmake but "make install" doesn't install FindLibevent.cmake. It causes an error with find_package(Thrift) like the following:
   
       -- Found thrift: /tmp/xxx/tmp/local
       -- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.so (found version "1.2.13")
       -- Found OpenSSL: /usr/lib/x86_64-linux-gnu/libcrypto.so (found version "3.0.7")
       CMake Warning at /usr/share/cmake-3.24/Modules/CMakeFindDependencyMacro.cmake:47 (find_package):
         By not providing "FindLibevent.cmake" in CMAKE_MODULE_PATH this project has
         asked CMake to find a package configuration file provided by "Libevent",
         but CMake did not find one.
   
         Could not find a package configuration file provided by "Libevent" with any
         of the following names:
   
           LibeventConfig.cmake
           libevent-config.cmake
   
         Add the installation prefix of "Libevent" to CMAKE_PREFIX_PATH or set
         "Libevent_DIR" to a directory containing one of the above files.  If
         "Libevent" provides a separate development package or SDK, be sure it has
         been installed.
       Call Stack (most recent call first):
         /tmp/xxx/tmp/local/lib/cmake/thrift/ThriftConfig.cmake:93 (find_dependency)
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jimexist merged pull request #2726: THRIFT-5668: Install FindLibevent.cmake

["Jimexist (via GitHub)" <gi...@apache.org>]

Jimexist merged PR #2726:
URL: https://github.com/apache/thrift/pull/2726


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org