You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "matthewgapp (via GitHub)" <gi...@apache.org> on 2024/01/11 00:47:41 UTC
[PR] Recursive CTEs: Stage 1 - add config flag [arrow-datafusion]
matthewgapp opened a new pull request, #8828:
URL: https://github.com/apache/arrow-datafusion/pull/8828
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Recursive CTEs: Stage 1 - add config flag [arrow-datafusion]
Posted by "matthewgapp (via GitHub)" <gi...@apache.org>.
matthewgapp commented on PR #8828:
URL: https://github.com/apache/arrow-datafusion/pull/8828#issuecomment-1889860184
> I think some tests need updating to get the CI run clean here
Yeah, this is still a draft, so not quite ready for CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Recursive CTEs: Stage 1 - add config flag [arrow-datafusion]
Posted by "matthewgapp (via GitHub)" <gi...@apache.org>.
matthewgapp commented on PR #8828:
URL: https://github.com/apache/arrow-datafusion/pull/8828#issuecomment-1890341147
> > I think some tests need updating to get the CI run clean here
>
>
>
> Yeah, this is still a draft, so not quite ready for CI. I'm going to be readying these PRs this afternoon and will mark them Ready for review when done.
Spent most of my time today digging into the bug fix and repo of the bug(s) we're seeing downstream. Hope to finish that and then clean up these PRs this weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Recursive CTEs: Stage 1 - add config flag [arrow-datafusion]
Posted by "matthewgapp (via GitHub)" <gi...@apache.org>.
matthewgapp commented on PR #8828:
URL: https://github.com/apache/arrow-datafusion/pull/8828#issuecomment-1892813036
> Thinking that I'll have these three PRs ready for review sometime tomorrow afternoon.
Think it's ready for review :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Recursive CTEs: Stage 1 - add config flag [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #8828:
URL: https://github.com/apache/arrow-datafusion/pull/8828#issuecomment-1889838406
I think some tests need updating to get the CI run clean here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Recursive CTEs: Stage 1 - add config flag [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #8828:
URL: https://github.com/apache/arrow-datafusion/pull/8828#discussion_r1453312591
##########
testing:
##########
Review Comment:
I think you could potentially update the submodule in main
Mabye like
```shell
cd datafusion
cd testing
# checkout submodule at version that datafusion/main is checked out
git checkout 98fceec
cd ..
git commit -a -m 'restore testing pin'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Recursive CTEs: Stage 1 - add config flag [arrow-datafusion]
Posted by "matthewgapp (via GitHub)" <gi...@apache.org>.
matthewgapp commented on PR #8828:
URL: https://github.com/apache/arrow-datafusion/pull/8828#issuecomment-1891305054
> > > I think some tests need updating to get the CI run clean here
> >
> >
> > Yeah, this is still a draft, so not quite ready for CI. I'm going to be readying these PRs this afternoon and will mark them Ready for review when done.
>
> Spent most of my time today digging into the repro and solution to the bug(s) we're seeing downstream. Hope to finish that and then clean up these PRs this weekend.
Thinking that I'll have these three PRs ready for review sometime tomorrow afternoon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Recursive CTEs: Stage 1 - add config flag [arrow-datafusion]
Posted by "matthewgapp (via GitHub)" <gi...@apache.org>.
matthewgapp commented on code in PR #8828:
URL: https://github.com/apache/arrow-datafusion/pull/8828#discussion_r1452984215
##########
testing:
##########
Review Comment:
for the life of me I can't figure out how to remove this change from the PR (after reseting/deinit-ing/init-ing/updating/every-verbing the submodule) ðŸ˜ðŸ˜. Any advice/best-practices here would be appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Recursive CTEs: Stage 1 - add config flag [arrow-datafusion]
Posted by "matthewgapp (via GitHub)" <gi...@apache.org>.
matthewgapp commented on code in PR #8828:
URL: https://github.com/apache/arrow-datafusion/pull/8828#discussion_r1453834964
##########
testing:
##########
Review Comment:
Thank you! That worked. Think I better understand submodules now after fighting with it for a bit 🙃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Recursive CTEs: Stage 1 - add config flag [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #8828:
URL: https://github.com/apache/arrow-datafusion/pull/8828#issuecomment-1887926900
Thanks @matthewgapp -- what would you think about filing a ticket with the implementation plan described in https://github.com/apache/arrow-datafusion/pull/7581#issuecomment-1886010269 (or maybe we can put it on https://github.com/apache/arrow-datafusion/issues/462 itself)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Recursive CTEs: Stage 1 - add config flag [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #8828:
URL: https://github.com/apache/arrow-datafusion/pull/8828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org