[GitHub] [cloudstack] ravening commented on a change in pull request #5730: Enhancement: create Shared networks and VPC private gateways by users

[GitBox <gi...@apache.org>]

ravening commented on a change in pull request #5730:
URL: https://github.com/apache/cloudstack/pull/5730#discussion_r759170259



##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -2764,6 +2770,21 @@ public Network doInTransaction(final TransactionStatus status) {
         return network;
     }
 
+    @Override
+    public boolean isSharedNetworkWithoutSpecifyVlan(NetworkOffering offering) {
+        if (offering == null || offering.getTrafficType() != TrafficType.Guest || offering.getGuestType() != GuestType.Shared) {
+            return false;
+        }
+        if (! offering.isSpecifyVlan()) {

Review comment:
       simplify this if checkeck to `return offering.isSpecifyVlan()` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org