You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/07/14 19:18:47 UTC

[GitHub] [kafka] lbradstreet commented on a change in pull request #9022: KAFKA-10158: Improve test behavior and resolve flakiness of test...

lbradstreet commented on a change in pull request #9022:
URL: https://github.com/apache/kafka/pull/9022#discussion_r454586912



##########
File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala
##########
@@ -672,11 +677,9 @@ class TopicCommandWithAdminClientTest extends KafkaServerTestHarness with Loggin
     adminClient.createTopics(
       Collections.singletonList(new NewTopic(testTopicName, partitions, replicationFactor).configs(configMap))).all().get()
     waitForTopicCreated(testTopicName)
-    TestUtils.generateAndProduceMessages(servers, testTopicName, numMessages = 10, acks = -1)
+    TestUtils.generateAndProduceMessages(servers, testTopicName, numMessages = 1000, acks = -1)

Review comment:
       It might be worth adding a comment somewhere in `testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress` to describe what was done in the replicaFetchMaxBytes def and why.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org