You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tubemq.apache.org by GitBox <gi...@apache.org> on 2020/12/02 11:55:27 UTC
[GitHub] [incubator-tubemq] gosonzhang opened a new pull request #335: [TUBEMQ-439]Add Cli field Scheme definition
gosonzhang opened a new pull request #335:
URL: https://github.com/apache/incubator-tubemq/pull/335
It is found that the field tokens used to interact with users in CLI or HTTP API requests have a relatively large overlap. This issue is hoped that a unified field output goal can be achieved through the field definition scheme, and the same attribute has a unified attribute definition and interpretation, which reduces the user's learning and use cost To maintain the consistency of interface interaction
Because CLI and HTTP API are not a complete closed loop, and there are still compatibility issues, the existing ones are defined first, and then the new field definitions and interfaces will be gradually standardized. When appropriate, we will update the outdated interfaces.
It should be noted that after the version is released, the existing definition fields in scheme cannot be modified, only new fields can be added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] codecov-io commented on pull request #335: [TUBEMQ-439]Add Cli field Scheme definition
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #335:
URL: https://github.com/apache/incubator-tubemq/pull/335#issuecomment-737185482
# [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/335?src=pr&el=h1) Report
> Merging [#335](https://codecov.io/gh/apache/incubator-tubemq/pull/335?src=pr&el=desc) (fd6e9a9) into [TUBEMQ-430](https://codecov.io/gh/apache/incubator-tubemq/commit/c9fbda7f5140bca4db8f5a09c4dfa02a785a62d1?el=desc) (c9fbda7) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-tubemq/pull/335?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## TUBEMQ-430 #335 +/- ##
============================================
Coverage 7.94% 7.95%
- Complexity 465 468 +3
============================================
Files 254 255 +1
Lines 27372 27404 +32
Branches 4479 4479
============================================
+ Hits 2175 2179 +4
- Misses 24728 24755 +27
- Partials 469 470 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-tubemq/pull/335?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/tubemq/server/broker/web/BrokerAdminServlet.java](https://codecov.io/gh/apache/incubator-tubemq/pull/335/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9icm9rZXIvd2ViL0Jyb2tlckFkbWluU2VydmxldC5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...pache/tubemq/server/common/fielddef/CliArgDef.java](https://codecov.io/gh/apache/incubator-tubemq/pull/335/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vZmllbGRkZWYvQ2xpQXJnRGVmLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...che/tubemq/server/common/fielddef/WebFieldDef.java](https://codecov.io/gh/apache/incubator-tubemq/pull/335/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vZmllbGRkZWYvV2ViRmllbGREZWYuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [.../tubemq/server/common/utils/WebParameterUtils.java](https://codecov.io/gh/apache/incubator-tubemq/pull/335/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vdXRpbHMvV2ViUGFyYW1ldGVyVXRpbHMuamF2YQ==) | `2.47% <ø> (ø)` | `8.00 <0.00> (ø)` | |
| [.../producer/qltystats/DefaultBrokerRcvQltyStats.java](https://codecov.io/gh/apache/incubator-tubemq/pull/335/diff?src=pr&el=tree#diff-dHViZW1xLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL2NsaWVudC9wcm9kdWNlci9xbHR5c3RhdHMvRGVmYXVsdEJyb2tlclJjdlFsdHlTdGF0cy5qYXZh) | `45.70% <0.00%> (+0.39%)` | `21.00% <0.00%> (+1.00%)` | |
| [.../tubemq/corebase/policies/FlowCtrlRuleHandler.java](https://codecov.io/gh/apache/incubator-tubemq/pull/335/diff?src=pr&el=tree#diff-dHViZW1xLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1YmVtcS9jb3JlYmFzZS9wb2xpY2llcy9GbG93Q3RybFJ1bGVIYW5kbGVyLmphdmE=) | `44.57% <0.00%> (+0.58%)` | `35.00% <0.00%> (+1.00%)` | |
| [.../apache/tubemq/corebase/policies/FlowCtrlItem.java](https://codecov.io/gh/apache/incubator-tubemq/pull/335/diff?src=pr&el=tree#diff-dHViZW1xLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1YmVtcS9jb3JlYmFzZS9wb2xpY2llcy9GbG93Q3RybEl0ZW0uamF2YQ==) | `40.00% <0.00%> (+1.11%)` | `9.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/335?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/335?src=pr&el=footer). Last update [c9fbda7...fd6e9a9](https://codecov.io/gh/apache/incubator-tubemq/pull/335?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] gosonzhang merged pull request #335: [TUBEMQ-439]Add Cli field Scheme definition
Posted by GitBox <gi...@apache.org>.
gosonzhang merged pull request #335:
URL: https://github.com/apache/incubator-tubemq/pull/335
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] codecov-io edited a comment on pull request #335: [TUBEMQ-439]Add Cli field Scheme definition
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #335:
URL: https://github.com/apache/incubator-tubemq/pull/335#issuecomment-737185482
# [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/335?src=pr&el=h1) Report
> Merging [#335](https://codecov.io/gh/apache/incubator-tubemq/pull/335?src=pr&el=desc) (35de731) into [TUBEMQ-430](https://codecov.io/gh/apache/incubator-tubemq/commit/c9fbda7f5140bca4db8f5a09c4dfa02a785a62d1?el=desc) (c9fbda7) will **decrease** coverage by `0.03%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-tubemq/pull/335?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## TUBEMQ-430 #335 +/- ##
===============================================
- Coverage 7.94% 7.91% -0.04%
- Complexity 465 466 +1
===============================================
Files 254 255 +1
Lines 27372 27404 +32
Branches 4479 4479
===============================================
- Hits 2175 2169 -6
- Misses 24728 24763 +35
- Partials 469 472 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-tubemq/pull/335?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/tubemq/server/broker/web/BrokerAdminServlet.java](https://codecov.io/gh/apache/incubator-tubemq/pull/335/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9icm9rZXIvd2ViL0Jyb2tlckFkbWluU2VydmxldC5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...pache/tubemq/server/common/fielddef/CliArgDef.java](https://codecov.io/gh/apache/incubator-tubemq/pull/335/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vZmllbGRkZWYvQ2xpQXJnRGVmLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...che/tubemq/server/common/fielddef/WebFieldDef.java](https://codecov.io/gh/apache/incubator-tubemq/pull/335/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vZmllbGRkZWYvV2ViRmllbGREZWYuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../tubemq/server/common/utils/WebParameterUtils.java](https://codecov.io/gh/apache/incubator-tubemq/pull/335/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vdXRpbHMvV2ViUGFyYW1ldGVyVXRpbHMuamF2YQ==) | `2.47% <ø> (ø)` | `8.00 <0.00> (ø)` | |
| [.../java/org/apache/flume/sink/tubemq/TubemqSink.java](https://codecov.io/gh/apache/incubator-tubemq/pull/335/diff?src=pr&el=tree#diff-dHViZW1xLWNvbm5lY3RvcnMvdHViZW1xLWNvbm5lY3Rvci1mbHVtZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZmx1bWUvc2luay90dWJlbXEvVHViZW1xU2luay5qYXZh) | `51.42% <0.00%> (-4.00%)` | `14.00% <0.00%> (ø%)` | |
| [.../producer/qltystats/DefaultBrokerRcvQltyStats.java](https://codecov.io/gh/apache/incubator-tubemq/pull/335/diff?src=pr&el=tree#diff-dHViZW1xLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL2NsaWVudC9wcm9kdWNlci9xbHR5c3RhdHMvRGVmYXVsdEJyb2tlclJjdlFsdHlTdGF0cy5qYXZh) | `45.70% <0.00%> (+0.39%)` | `21.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/335?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/335?src=pr&el=footer). Last update [c9fbda7...35de731](https://codecov.io/gh/apache/incubator-tubemq/pull/335?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org