[GitHub] [parquet-format] wgtmac commented on a diff in pull request #198: PARQUET-2264: Allow scale == precision for DecimalType

["wgtmac (via GitHub)" <gi...@apache.org>]

wgtmac commented on code in PR #198:
URL: https://github.com/apache/parquet-format/pull/198#discussion_r1159239875


##########
LogicalTypes.md:
##########
@@ -219,7 +219,7 @@ decimal point, and the precision stores the maximum number of digits supported
 in the unscaled value.
 
 If not specified, the scale is 0. Scale must be zero or a positive integer less
-than the precision. Precision is required and must be a non-zero positive
+than or equal to the precision. Precision is required and must be a non-zero positive

Review Comment:
   Thanks for the PR! Could you also add the comment to the thrift definition: https://github.com/apache/parquet-format/blob/master/src/main/thrift/parquet.thrift#L253 ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org