[GitHub] [iceberg] szehon-ho commented on a change in pull request #4241: Core: Add REST catalog adapter and tests

[GitBox <gi...@apache.org>]

szehon-ho commented on a change in pull request #4241:
URL: https://github.com/apache/iceberg/pull/4241#discussion_r816330118



##########
File path: api/src/main/java/org/apache/iceberg/util/CharSequenceSet.java
##########
@@ -152,4 +156,28 @@ public boolean removeAll(Collection<?> objects) {
   public void clear() {
     wrapperSet.clear();
   }
+
+  @Override
+  public boolean equals(Object o) {
+    if (this == o) {
+      return true;
+    }
+
+    if (o == null || getClass() != o.getClass()) {
+      return false;
+    }
+
+    CharSequenceSet that = (CharSequenceSet) o;
+    return wrapperSet.equals(that.wrapperSet);
+  }
+
+  @Override
+  public int hashCode() {
+    return Objects.hash(wrapperSet);
+  }
+
+  @Override
+  public String toString() {
+    return "CharSequenceSet({" + Streams.stream(iterator()).collect(Collectors.joining(", ")) + "})";

Review comment:
       Nit, Collectors.joining seems to also take prefix, suffix argument, instead of adding them manually?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org