You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/08/02 13:37:24 UTC

[GitHub] zentol commented on a change in pull request #6477: [FLINK-10027] Add logging to StreamingFileSink

zentol commented on a change in pull request #6477: [FLINK-10027] Add logging to StreamingFileSink
URL: https://github.com/apache/flink/pull/6477#discussion_r207218923
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/Buckets.java
 ##########
 @@ -185,35 +193,29 @@ void publishUpToCheckpoint(long checkpointId) throws IOException {
 
 	void snapshotState(
 			final long checkpointId,
-			final ListState<byte[]> bucketStates,
-			final ListState<Long> partCounterState) throws Exception {
+			final ListState<byte[]> bucketStatesContainer,
+			final ListState<Long> partCounterStateContainer) throws Exception {
+		Preconditions.checkState(fsWriter != null && bucketStateSerializer != null);
 
-		Preconditions.checkState(
-				fileSystemWriter != null && bucketStateSerializer != null,
-				"sink has not been initialized"
 
 Review comment:
   keep error message

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services