You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/07 08:49:02 UTC

[GitHub] [flink] alpreu commented on a diff in pull request #19807: [FLINK-27185][connectors] Convert connector-jdbc module to assertj

alpreu commented on code in PR #19807:
URL: https://github.com/apache/flink/pull/19807#discussion_r890951037


##########
flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunctionTest.java:
##########
@@ -160,7 +160,7 @@ public void testEvalWithCacheMissingKeyNegative() throws Exception {
                         StringData.fromString("1"),
                         StringData.fromString("51-c1"),
                         StringData.fromString("51-c2")));
-        assertEquals(cache.getIfPresent(keyRow), expectedOutput);
+        assertThat(expectedOutput).isEqualTo(cache.getIfPresent(keyRow));

Review Comment:
   Unfortunately the script cannot fix assertions were the expected-actual order was wrong before already. I fixed this and a few others manually but might have missed a few



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org