[GitHub] [airflow] potiuk commented on pull request #13440: Additional properties should be allowed in provider schema

[GitBox <gi...@apache.org>]

potiuk commented on pull request #13440:
URL: https://github.com/apache/airflow/pull/13440#issuecomment-753493964


   I've found a potential problem with providers.yaml and schema. Seems that providers that next wave of providers we are going to release will not be compatible with 2.0.0 because they already have 'logo' added as additional property in yaml and providers will not be able to register themselves (schema will fail validation)
   
   Changing additionalProeperties to "true" solves the problem in 'future-compatible' way, however this does not help for 2.0.0 users who won't be able to discover future providers.
   
   Taking into account, however that 2.0.0 has a number of problems and 2.0.1 is going to be really the first 'stable` release I think, it might make sense to add >=2.0.1 limitation in the future providers (I guess that might motivate users of 2.0.0 to upgrade to 2.0.1). We could also yank 2.0.0 release (I think we should do it regardless with the number of small, but annoying problems we have). 
   
   Let me know WDYT.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org