You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "gaoxingliang (via GitHub)" <gi...@apache.org> on 2025/05/21 02:29:58 UTC
[PR] feat(wolf): improve the error message when requesting to wolf failed [apisix]
gaoxingliang opened a new pull request, #12238:
URL: https://github.com/apache/apisix/pull/12238
improve the error message when requesting to wolf failed and if the username or password is wrong, give a more readable message.
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
improve the plugin `wolf-rbac`
#### Which issue(s) this PR fixes:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->
Fixes #12231
The main changes:
1, add a optional property `error_message` to customize the error message if request wolf failed. because the user may don't need to know what wolf is.
2, if the username / password is wrong or user not found, return a more readable message. and http code to 401 instead of 200.
3, test and doc is changed too.
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [x] I have added tests corresponding to this change
- [x] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(wolf): improve the error message when requesting to wolf failed [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #12238: feat(wolf): improve the error message when requesting to wolf failed
URL: https://github.com/apache/apisix/pull/12238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(wolf): improve the error message when requesting to wolf failed [apisix]
Posted by "gaoxingliang (via GitHub)" <gi...@apache.org>.
gaoxingliang commented on PR #12238:
URL: https://github.com/apache/apisix/pull/12238#issuecomment-2899783771
Hi @moonming, this pr provides the ability to hide the wolf existence for user. previous version doesn't provide this ability. that's to say: if a user provides a wrong username or password, or any other error encountered, the user will receive a message:
`request to wolf failed`.
This pr provides a setting to customize this message eg, you can set it to : 'auth fail encountered.'
Or do you mean I need to set the default error message to some other error instead of previous `request to wolf...`? I set it as default to keep compabalility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(wolf): improve the error message when requesting to wolf failed [apisix]
Posted by "moonming (via GitHub)" <gi...@apache.org>.
moonming commented on PR #12238:
URL: https://github.com/apache/apisix/pull/12238#issuecomment-2896931808
@gaoxingliang thanks for this PR. I have a question, is it necessary to let the client know about the existence of the Wolf plugin? Of course, this was not introduced by this PR. Is just log local error ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(wolf): improve the error message when requesting to wolf failed [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12238:
URL: https://github.com/apache/apisix/pull/12238#issuecomment-3311555603
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(wolf): improve the error message when requesting to wolf failed [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #12238:
URL: https://github.com/apache/apisix/pull/12238#issuecomment-3030324083
Hi @gaoxingliang, can you get CI to pass?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(wolf): improve the error message when requesting to wolf failed [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12238:
URL: https://github.com/apache/apisix/pull/12238#issuecomment-3418154103
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org