You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Karam Singh (JIRA)" <ji...@apache.org> on 2009/02/25 14:00:01 UTC
[jira] Created: (HADOOP-5327) Job files for a job failing because
of ACLs are not clean from the system directory
Job files for a job failing because of ACLs are not clean from the system directory
------------------------------------------------------------------------------------
Key: HADOOP-5327
URL: https://issues.apache.org/jira/browse/HADOOP-5327
Project: Hadoop Core
Issue Type: Bug
Affects Versions: 0.20.0
Reporter: Karam Singh
Jobs which failed because of ACLs gets added during JT restart recovery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5327) Job files for a job failing because
of ACLs are not clean from the system directory
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680781#action_12680781 ]
Amar Kamat commented on HADOOP-5327:
------------------------------------
ant test passed on my box.
> Job files for a job failing because of ACLs are not clean from the system directory
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5327
> URL: https://issues.apache.org/jira/browse/HADOOP-5327
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Karam Singh
> Assignee: Amar Kamat
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5327-v2.3.patch, HADOOP-5327-v2.6.patch
>
>
> Jobs which failed because of ACLs gets added during JT restart recovery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5327) Job files for a job failing because
of ACLs are not clean from the system directory
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680072#action_12680072 ]
Amar Kamat commented on HADOOP-5327:
------------------------------------
Job directory cleanup upon submission failure can be addressed in another jira.
bq. The job was running in the first place, and after restart it can no longer run because the ACLs were changed.
HADOOP-4638 and HADOOP-5392 will take care of this. In such cases, the job will not be added and hence a KILL-JOB will be issued to all the trackers.
> Job files for a job failing because of ACLs are not clean from the system directory
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5327
> URL: https://issues.apache.org/jira/browse/HADOOP-5327
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Karam Singh
> Assignee: Amar Kamat
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5327-v2.3.patch
>
>
> Jobs which failed because of ACLs gets added during JT restart recovery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-5327) Job files for a job failing because
of ACLs are not clean from the system directory
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amar Kamat reassigned HADOOP-5327:
----------------------------------
Assignee: Amar Kamat
> Job files for a job failing because of ACLs are not clean from the system directory
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5327
> URL: https://issues.apache.org/jira/browse/HADOOP-5327
> Project: Hadoop Core
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: Karam Singh
> Assignee: Amar Kamat
>
> Jobs which failed because of ACLs gets added during JT restart recovery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5327) Job files for a job failing because
of ACLs are not clean from the system directory
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amar Kamat updated HADOOP-5327:
-------------------------------
Attachment: HADOOP-5327-v2.8.patch
Attaching a patch incorporating Hemanth's comments. Result of test-patch
{code}
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 6 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
{code}
> Job files for a job failing because of ACLs are not clean from the system directory
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5327
> URL: https://issues.apache.org/jira/browse/HADOOP-5327
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Karam Singh
> Assignee: Amar Kamat
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5327-v2.3.patch, HADOOP-5327-v2.6.patch, HADOOP-5327-v2.8.patch
>
>
> Jobs which failed because of ACLs gets added during JT restart recovery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5327) Job files for a job failing because
of ACLs are not clean from the system directory
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amar Kamat updated HADOOP-5327:
-------------------------------
Attachment: HADOOP-5327-v2.6.patch
Attaching a patch incorporating Hemanth's comments. Result of test-patch
[code}
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
{code}
> Job files for a job failing because of ACLs are not clean from the system directory
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5327
> URL: https://issues.apache.org/jira/browse/HADOOP-5327
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Karam Singh
> Assignee: Amar Kamat
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5327-v2.3.patch, HADOOP-5327-v2.6.patch
>
>
> Jobs which failed because of ACLs gets added during JT restart recovery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5327) Job files for a job failing because
of ACLs are not clean from the system directory
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley updated HADOOP-5327:
--------------------------------
Priority: Blocker (was: Major)
More details on HADOOP-5400 which was closed as a dup of this bug.
> Job files for a job failing because of ACLs are not clean from the system directory
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5327
> URL: https://issues.apache.org/jira/browse/HADOOP-5327
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Karam Singh
> Assignee: Amar Kamat
> Priority: Blocker
> Fix For: 0.20.0
>
>
> Jobs which failed because of ACLs gets added during JT restart recovery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5327) Job files for a job failing because
of ACLs are not clean from the system directory
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hemanth Yamijala updated HADOOP-5327:
-------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this to branch 0.20 and trunk. Thanks, Amar !
> Job files for a job failing because of ACLs are not clean from the system directory
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5327
> URL: https://issues.apache.org/jira/browse/HADOOP-5327
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Karam Singh
> Assignee: Amar Kamat
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5327-v2.3.patch, HADOOP-5327-v2.6.patch, HADOOP-5327-v2.8.patch
>
>
> Jobs which failed because of ACLs gets added during JT restart recovery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5327) Job files for a job failing because
of ACLs are not clean from the system directory
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680828#action_12680828 ]
Hemanth Yamijala commented on HADOOP-5327:
------------------------------------------
Hi, looking good. Few comments:
- I think we should not do the cleanup from the system directory in the job tracker restart case. Like I wrote earlier on, I think this should follow the same path as a job being killed. In that case, the system directory may be cleaned up as part of the job completion, and may be needed until then.
- Can we rename getJobDirectory to getSystemJobDir() or something similar ?
- I think we need a test case in TestQueueManager which will check that the system directory is being cleaned up upon unsuccessful job submission due to ACLs. The check for the system directory being deleted in TestRecoveryManager will not be needed.
> Job files for a job failing because of ACLs are not clean from the system directory
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5327
> URL: https://issues.apache.org/jira/browse/HADOOP-5327
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Karam Singh
> Assignee: Amar Kamat
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5327-v2.3.patch, HADOOP-5327-v2.6.patch
>
>
> Jobs which failed because of ACLs gets added during JT restart recovery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5327) Job files for a job failing because
of ACLs are not clean from the system directory
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680136#action_12680136 ]
Hemanth Yamijala commented on HADOOP-5327:
------------------------------------------
Amar, I suggested we cleanup the files here because:
- The root cause of the issue is that job files are not deleted upon ACLs check failure.
- Deleting it then will not even cause this problem in a very large percentage of cases.
> Job files for a job failing because of ACLs are not clean from the system directory
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5327
> URL: https://issues.apache.org/jira/browse/HADOOP-5327
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Karam Singh
> Assignee: Amar Kamat
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5327-v2.3.patch
>
>
> Jobs which failed because of ACLs gets added during JT restart recovery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5327) Job files for a job failing because
of ACLs are not clean from the system directory
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679548#action_12679548 ]
Hemanth Yamijala commented on HADOOP-5327:
------------------------------------------
I think this patch should also add the system directory to the clean up thread in the code path where job submission fails due to ACLs. In a majority of the cases, this action alone will prevent the problem from happening in the first place. However, this is only in addition to the changes in the patch as they are still needed to take care of cases where the job tracker could be restarted before the clean up thread has had a chance to delete the system directory completely.
Regarding cleanup, there seem to be two different cases here:
- The job was never submitted in the first place
- The job was running in the first place, and after restart it can no longer run because the ACLs were changed.
I think the patch is cleanly handling the first case (with the comments incorporated). In the second case, ideally the job should be killed by the JobTracker so that all parts related to the job (system directory, running tasks, cleanup task, etc) are cleaned up properly. I am thinking handling the second case (which ideally should be rare) should be a separate jira. Thoughts ?
> Job files for a job failing because of ACLs are not clean from the system directory
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5327
> URL: https://issues.apache.org/jira/browse/HADOOP-5327
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Karam Singh
> Assignee: Amar Kamat
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5327-v2.3.patch
>
>
> Jobs which failed because of ACLs gets added during JT restart recovery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5327) Job files for a job failing because
of ACLs are not clean from the system directory
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amar Kamat updated HADOOP-5327:
-------------------------------
Status: Patch Available (was: Open)
> Job files for a job failing because of ACLs are not clean from the system directory
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5327
> URL: https://issues.apache.org/jira/browse/HADOOP-5327
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Karam Singh
> Assignee: Amar Kamat
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5327-v2.3.patch, HADOOP-5327-v2.6.patch, HADOOP-5327-v2.8.patch
>
>
> Jobs which failed because of ACLs gets added during JT restart recovery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5327) Job files for a job failing because
of ACLs are not clean from the system directory
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679539#action_12679539 ]
Hemanth Yamijala commented on HADOOP-5327:
------------------------------------------
Few comments:
- There's an import of a LoginException in JobTracker, which is not required.
- I feel it would be better to overload checkAccess to have an additional parameter UGI. This is because both modes (with and without UGI) are still valid and hence it would be more convenient and fewer changes to code if we can create the overloaded API.
- Can you please correct the comment on checkAccess, to remove references to ownerAllowed, as it is no longer used. This is not introduced in this patch, but since you are modifying the comment, it may make sense to correct this as well.
- In the test cases, why is dfs.permissions set to false ? Is it because the credentials of the new job (with invalid ACLs) is being submitted as a different user and hence there will be problems to write to dfs ? Does this happen, even though you are not using the MiniDFSCluster ?
- A general question is about whether any cleanup is required for the job which fails ACLs. For instance, should we delete the job folder in the system directory, delete the history files etc ? I am not sure if it is required. Any thoughts ?
> Job files for a job failing because of ACLs are not clean from the system directory
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5327
> URL: https://issues.apache.org/jira/browse/HADOOP-5327
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Karam Singh
> Assignee: Amar Kamat
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5327-v2.3.patch
>
>
> Jobs which failed because of ACLs gets added during JT restart recovery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5327) Job files for a job failing because
of ACLs are not clean from the system directory
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681757#action_12681757 ]
Hudson commented on HADOOP-5327:
--------------------------------
Integrated in Hadoop-trunk #778 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/778/])
> Job files for a job failing because of ACLs are not clean from the system directory
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5327
> URL: https://issues.apache.org/jira/browse/HADOOP-5327
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Karam Singh
> Assignee: Amar Kamat
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5327-v2.3.patch, HADOOP-5327-v2.6.patch, HADOOP-5327-v2.8.patch
>
>
> Jobs which failed because of ACLs gets added during JT restart recovery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5327) Job files for a job failing because
of ACLs are not clean from the system directory
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hemanth Yamijala updated HADOOP-5327:
-------------------------------------
Component/s: mapred
Priority: Blocker (was: Major)
Fix Version/s: 0.20.0
> Job files for a job failing because of ACLs are not clean from the system directory
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5327
> URL: https://issues.apache.org/jira/browse/HADOOP-5327
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Karam Singh
> Assignee: Amar Kamat
> Priority: Blocker
> Fix For: 0.20.0
>
>
> Jobs which failed because of ACLs gets added during JT restart recovery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5327) Job files for a job failing because
of ACLs are not clean from the system directory
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681163#action_12681163 ]
Amar Kamat commented on HADOOP-5327:
------------------------------------
Patch applies to 0.20 branch and relevant tests pass.
> Job files for a job failing because of ACLs are not clean from the system directory
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5327
> URL: https://issues.apache.org/jira/browse/HADOOP-5327
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Karam Singh
> Assignee: Amar Kamat
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5327-v2.3.patch, HADOOP-5327-v2.6.patch, HADOOP-5327-v2.8.patch
>
>
> Jobs which failed because of ACLs gets added during JT restart recovery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5327) Job files for a job failing because
of ACLs are not clean from the system directory
Posted by "Sameer Paranjpye (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sameer Paranjpye updated HADOOP-5327:
-------------------------------------
Priority: Major (was: Blocker)
> Job files for a job failing because of ACLs are not clean from the system directory
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5327
> URL: https://issues.apache.org/jira/browse/HADOOP-5327
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Karam Singh
> Assignee: Amar Kamat
> Fix For: 0.20.0
>
>
> Jobs which failed because of ACLs gets added during JT restart recovery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5327) Job files for a job failing because
of ACLs are not clean from the system directory
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681187#action_12681187 ]
Amar Kamat commented on HADOOP-5327:
------------------------------------
Manually tested this patch on single node cluster
# invalid job submitted : system-dir cleaned up
# acls changed upon restart : files are retained but job is not accepted
> Job files for a job failing because of ACLs are not clean from the system directory
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5327
> URL: https://issues.apache.org/jira/browse/HADOOP-5327
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Karam Singh
> Assignee: Amar Kamat
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5327-v2.3.patch, HADOOP-5327-v2.6.patch, HADOOP-5327-v2.8.patch
>
>
> Jobs which failed because of ACLs gets added during JT restart recovery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5327) Job files for a job failing because
of ACLs are not clean from the system directory
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amar Kamat updated HADOOP-5327:
-------------------------------
Attachment: HADOOP-5327-v2.3.patch
Attaching a patch that checks the acls in recovery before adding the job. Result of test-patch
{code}
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
{code}
> Job files for a job failing because of ACLs are not clean from the system directory
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5327
> URL: https://issues.apache.org/jira/browse/HADOOP-5327
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Karam Singh
> Assignee: Amar Kamat
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5327-v2.3.patch
>
>
> Jobs which failed because of ACLs gets added during JT restart recovery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5327) Job files for a job failing because
of ACLs are not clean from the system directory
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681168#action_12681168 ]
Hemanth Yamijala commented on HADOOP-5327:
------------------------------------------
Code changes look fine. +1.
> Job files for a job failing because of ACLs are not clean from the system directory
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5327
> URL: https://issues.apache.org/jira/browse/HADOOP-5327
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Karam Singh
> Assignee: Amar Kamat
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5327-v2.3.patch, HADOOP-5327-v2.6.patch, HADOOP-5327-v2.8.patch
>
>
> Jobs which failed because of ACLs gets added during JT restart recovery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5327) Job files for a job failing because
of ACLs are not clean from the system directory
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681266#action_12681266 ]
Amar Kamat commented on HADOOP-5327:
------------------------------------
TestCLI failed on my box but also on trunk. Rest all tests passed.
> Job files for a job failing because of ACLs are not clean from the system directory
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5327
> URL: https://issues.apache.org/jira/browse/HADOOP-5327
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Karam Singh
> Assignee: Amar Kamat
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: HADOOP-5327-v2.3.patch, HADOOP-5327-v2.6.patch, HADOOP-5327-v2.8.patch
>
>
> Jobs which failed because of ACLs gets added during JT restart recovery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.