Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests [kafka]

["jsancio (via GitHub)" <gi...@apache.org>]

jsancio commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r2060745648


##########
raft/src/test/java/org/apache/kafka/raft/MockLog.java:
##########
@@ -626,6 +676,14 @@ public String toString() {
         );
     }
 
+    public VoterSet lastVoterSet() {
+        return lastVoterSet;
+    }
+
+    public VoterSet lastCommittedVoterSet() {
+        return lastCommittedVoterSet;
+    }

Review Comment:
   I don't see any test that show this functionality is correct. Please add test to MockLogTest.



##########
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##########
@@ -734,12 +733,13 @@ private static class ScheduledUntilConditionMetEvent extends Event {
         final Supplier<Boolean> exitCondition;
 
         protected ScheduledUntilConditionMetEvent(Runnable action,
-                                int eventId,
-                                Random random,
-                                long deadlineMs,
-                                int periodMs,
-                                int jitterMs,
-                                Supplier<Boolean> exitCondition) {
+            int eventId,

Review Comment:
   Please use this formatting:
   ```java
   protected ScheduledUntilConditionMetEvent(
       Runnable action,
       int eventId,
       ...
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org