You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by gi...@git.apache.org on 2017/07/12 22:55:40 UTC

[GitHub] rdhabalia opened a new pull request #561: CPP release baseCommand after serializing it

rdhabalia opened a new pull request #561: CPP release baseCommand after serializing it
URL: https://github.com/apache/incubator-pulsar/pull/561
 
 
   ### Motivation
   
   if `CmsClient` has created producers for batch and non-batch topics  then client shows invalid `msgRateIn` for non-batch topic.
   **root cause:**
   client-lib uses singleton `proto-BaseCommand` to get `send (cmd.mutable_send())` cmd. If application uses batch and non-batch producers then batch-producer sets `num_message` into the command and same command used by non-batch producer which picks up this stale invalid value and sends invalid `num_batch_msg` to broker for monitoring. 
   
   
   ### Modifications
   
   - release command after serializing send-command to reset its value.
   - for concurrent lookup requests : use new BaseCommand to create lookup-command.
   
   ### Result
   
   - client sends correct num_batch_msg to broker
   - make binary lookup threadsafe.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services