You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/06/05 05:33:47 UTC

[GitHub] [apisix] tao12345666333 opened a new pull request #4379: chore: change consumer name max length match with route name

tao12345666333 opened a new pull request #4379:
URL: https://github.com/apache/apisix/pull/4379


   Signed-off-by: Jintao Zhang <zh...@gmail.com>
   
   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   change consumer name's max length to match with route name.
   
   ref:  https://github.com/apache/apisix-ingress-controller/pull/529
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] tao12345666333 commented on a change in pull request #4379: chore: change consumer name max length match with route name

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #4379:
URL: https://github.com/apache/apisix/pull/4379#discussion_r646244857



##########
File path: apisix/schema_def.lua
##########
@@ -620,7 +620,7 @@ _M.consumer = {
     type = "object",
     properties = {
         username = {
-            type = "string", minLength = 1, maxLength = 32,
+            type = "string", minLength = 1, maxLength = 100,

Review comment:
       ```suggestion
               type = "string", minLength = 1, maxLength = rule_name_def.maxLength,
   ```
   
   @spacewander Do you mean referencing this field separately?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] juzhiyuan commented on pull request #4379: chore: change consumer name max length match with route name

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #4379:
URL: https://github.com/apache/apisix/pull/4379#issuecomment-855344214


   Ok


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on pull request #4379: chore: change consumer name max length match with route name

Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #4379:
URL: https://github.com/apache/apisix/pull/4379#issuecomment-855339508


   Will this change affect the dashboard? @nic-chen @juzhiyuan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander merged pull request #4379: chore: change consumer name max length match with route name

Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #4379:
URL: https://github.com/apache/apisix/pull/4379


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] nic-chen commented on pull request #4379: chore: change consumer name max length match with route name

Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #4379:
URL: https://github.com/apache/apisix/pull/4379#issuecomment-855344032


   > Will this change affect the dashboard? @nic-chen @juzhiyuan
   
   Need to modify the length limit accordingly. We could update the dashboard after this PR merged.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org