You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/03/11 16:36:19 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #3845: Add timezone support to JSON reader
tustvold opened a new pull request, #3845:
URL: https://github.com/apache/arrow-rs/pull/3845
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3845: Add timezone support to JSON reader
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #3845:
URL: https://github.com/apache/arrow-rs/pull/3845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #3845: Add timezone support to JSON reader
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #3845:
URL: https://github.com/apache/arrow-rs/pull/3845#discussion_r1140290622
##########
arrow-array/src/types.rs:
##########
@@ -287,30 +287,28 @@ impl ArrowTemporalType for DurationMicrosecondType {}
impl ArrowTemporalType for DurationNanosecondType {}
/// A timestamp type allows us to create array builders that take a timestamp.
-pub trait ArrowTimestampType: ArrowTemporalType {
+pub trait ArrowTimestampType: ArrowTemporalType<Native = i64> {
Review Comment:
I don't understand how these are sealed -- https://docs.rs/arrow/35.0.0/arrow/datatypes/trait.ArrowTimestampType.html
Maybe we should add a doc commen note here explaining that they are sealed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3845: Add timezone support to JSON reader
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #3845:
URL: https://github.com/apache/arrow-rs/pull/3845#discussion_r1133117710
##########
arrow-array/src/types.rs:
##########
@@ -287,30 +287,28 @@ impl ArrowTemporalType for DurationMicrosecondType {}
impl ArrowTemporalType for DurationNanosecondType {}
/// A timestamp type allows us to create array builders that take a timestamp.
-pub trait ArrowTimestampType: ArrowTemporalType {
+pub trait ArrowTimestampType: ArrowTemporalType<Native = i64> {
Review Comment:
This is not a breaking change as these types are sealed, but it simplifies generic code as i64 is guaranteed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3845: Add timezone support to JSON reader
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #3845:
URL: https://github.com/apache/arrow-rs/pull/3845#discussion_r1140292898
##########
arrow-array/src/types.rs:
##########
@@ -287,30 +287,28 @@ impl ArrowTemporalType for DurationMicrosecondType {}
impl ArrowTemporalType for DurationNanosecondType {}
/// A timestamp type allows us to create array builders that take a timestamp.
-pub trait ArrowTimestampType: ArrowTemporalType {
+pub trait ArrowTimestampType: ArrowTemporalType<Native = i64> {
Review Comment:
Oh, I assumed they were, they definitely should be :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3845: Add timezone support to JSON reader
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #3845:
URL: https://github.com/apache/arrow-rs/pull/3845#discussion_r1140308114
##########
arrow-array/src/types.rs:
##########
@@ -287,30 +287,28 @@ impl ArrowTemporalType for DurationMicrosecondType {}
impl ArrowTemporalType for DurationNanosecondType {}
/// A timestamp type allows us to create array builders that take a timestamp.
-pub trait ArrowTimestampType: ArrowTemporalType {
+pub trait ArrowTimestampType: ArrowTemporalType<Native = i64> {
Review Comment:
https://github.com/apache/arrow-rs/pull/3882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org