You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/05 14:24:31 UTC

[GitHub] [airflow] XD-DENG commented on a change in pull request #16264: Add flag to delete local logs after upload

XD-DENG commented on a change in pull request #16264:
URL: https://github.com/apache/airflow/pull/16264#discussion_r645996867



##########
File path: airflow/providers/amazon/aws/log/s3_task_handler.py
##########
@@ -93,7 +94,10 @@ def close(self):
             # read log and remove old logs to get just the latest additions
             with open(local_loc) as logfile:
                 log = logfile.read()
-            self.s3_write(log, remote_loc)
+            success = self.s3_write(log, remote_loc)
+            keep_local = conf.getboolean('logging', 'KEEP_LOCAL_LOGS')
+            if success and not keep_local:
+                shutil.rmtree(os.path.dirname(local_loc))

Review comment:
       What if something new is written to `local_loc` between `s3_write()` and `shutil.rmtree()`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org