You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by wangyum <gi...@git.apache.org> on 2017/11/02 08:45:14 UTC
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Replace GMT with history se...
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/19640
[SPARK-16986][WEB-UI] Replace GMT with history server side TimeZone.
## What changes were proposed in this pull request?
Replace GMT with history server side TimeZone. This both works for web UI and REST API.
## How was this patch tested?
manual tests
#### Before modifying
##### Web UI:
<img width="1280" alt="before" src="https://user-images.githubusercontent.com/5399861/32315920-19de825c-bfe9-11e7-9db6-edbf57d50792.png">
##### REST API:
<img width="571" alt="rest-before" src="https://user-images.githubusercontent.com/5399861/32316803-a647c034-bfec-11e7-8a04-411d23096a15.png">
#### After modifying
##### Web UI:
<img width="1283" alt="after" src="https://user-images.githubusercontent.com/5399861/32315949-24672c10-bfe9-11e7-93a3-73a31b34626f.png">
##### REST API:
<img width="572" alt="rest-after" src="https://user-images.githubusercontent.com/5399861/32316809-ac8e5912-bfec-11e7-852f-117acb284b62.png">
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wangyum/spark SPARK-16986
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19640.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19640
----
commit 17bddef90069e4119576c5d5da99042c005b4a43
Author: Yuming Wang <wg...@gmail.com>
Date: 2017-11-02T07:59:04Z
Replace GMT with history server side TimeZone.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/19640
It is client local time zone:
https://github.com/apache/spark/blob/master/core/src/main/resources/org/apache/spark/ui/static/historypage-common.js#L22
But the format is `11/14/2017, 7:16:34 PM`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Replace GMT with history server si...
Posted by jiangxb1987 <gi...@git.apache.org>.
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19640
cc @ueshin
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19640
why it has `PM` postfix at the end?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19640
It's a pure UI change so no compatibility issues. The new UI LGTM
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][CORE][WEB-UI] Support configure history se...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19640
Since a spark cluster may be used by people from different timezones, I think at server side we should just store seconds from unix epoch(time epoch), which is comparable though different timezones.
For the REST API, personally I think the server just need to send time epoch, but for ease of use, sending a timestamp string with GMT is acceptable.
For the UI part, I think it's more reasonable to interpret the time epoch using browser's local timezone, but we don't need a config.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][CORE][WEB-UI] Support configure history se...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by ajbozarth <gi...@git.apache.org>.
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/19640
I would tend to agree with @srowen on this, but from an implication side this is pretty good. I would suggest adding the timezone abbreviation to the end so the user knows it's in local time not GMT like previous. Also it may be better to move both the `padZeros` and `formateDate` functions to `utils.js` since they seem like they be used elsewhere eventually.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Converter Started, Complete...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r150842538
--- Diff: core/src/main/resources/org/apache/spark/ui/static/historypage.js ---
@@ -37,11 +37,6 @@ function makeIdNumeric(id) {
return resl;
}
-function formatDate(date) {
--- End diff --
Move to utils.js
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19640
sorry, I mean we should follow the format we use in completed, started...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83848 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83848/testReport)** for PR 19640 at commit [`4a78965`](https://github.com/apache/spark/commit/4a78965c22f11fbda7c9ba843ee266048bf6d319).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Converter Started, Complete...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r150868951
--- Diff: core/src/main/resources/org/apache/spark/ui/static/utils.js ---
@@ -46,3 +46,25 @@ function formatBytes(bytes, type) {
var i = Math.floor(Math.log(bytes) / Math.log(k));
return parseFloat((bytes / Math.pow(k, i)).toFixed(dm)) + ' ' + sizes[i];
}
+
+function padZeroes(num) {
+ return ("0" + num).slice(-2);
+}
+
+function formatTimeMillis(timeMillis) {
+ if (timeMillis <= 0) {
+ return "-";
+ } else {
+ var dt = new Date(timeMillis);
+ return dt.getFullYear() + "-" +
+ padZeroes(dt.getMonth() + 1) + "-" +
+ padZeroes(dt.getDate()) + " " +
+ padZeroes(dt.getHours()) + ":" +
+ padZeroes(dt.getMinutes()) + ":" +
+ padZeroes(dt.getSeconds());
+ }
+}
+
+function getTimeZone() {
+ return new Date().toString().match(/\(([A-Za-z\s].*)\)/)[1];
--- End diff --
how about `Intl.DateTimeFormat().resolvedOptions().timeZone`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83902/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Replace GMT with history server si...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83384/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83868/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by ajbozarth <gi...@git.apache.org>.
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/19640
I'd be ok with that
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][CORE][WEB-UI] Support configure history se...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83480/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83902 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83902/testReport)** for PR 19640 at commit [`08f5e68`](https://github.com/apache/spark/commit/08f5e6808847ad9ca383dc6f78ca3d733efc00ab).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19640
maybe we can move `formatDate` to util and use it there.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Converter Started, Complete...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r151034910
--- Diff: core/src/main/resources/org/apache/spark/ui/static/utils.js ---
@@ -46,3 +46,25 @@ function formatBytes(bytes, type) {
var i = Math.floor(Math.log(bytes) / Math.log(k));
return parseFloat((bytes / Math.pow(k, i)).toFixed(dm)) + ' ' + sizes[i];
}
+
+function padZeroes(num) {
+ return ("0" + num).slice(-2);
+}
+
+function formatTimeMillis(timeMillis) {
+ if (timeMillis <= 0) {
+ return "-";
+ } else {
+ var dt = new Date(timeMillis);
+ return dt.getFullYear() + "-" +
+ padZeroes(dt.getMonth() + 1) + "-" +
+ padZeroes(dt.getDate()) + " " +
+ padZeroes(dt.getHours()) + ":" +
+ padZeroes(dt.getMinutes()) + ":" +
+ padZeroes(dt.getSeconds());
+ }
+}
+
+function getTimeZone() {
+ return new Date().toString().match(/\(([A-Za-z\s].*)\)/)[1];
--- End diff --
This timeZone seems incorrect. Safari gets `Asia/Shanghai`, but Chrome gets `America/Chicago` on the same computer.
How about just include this change to release notes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Converter Started, Complete...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r150430605
--- Diff: core/src/main/resources/org/apache/spark/ui/static/historypage.js ---
@@ -38,8 +38,17 @@ function makeIdNumeric(id) {
}
function formatDate(date) {
- if (date <= 0) return "-";
- else return date.split(".")[0].replace("T", " ");
+ if (date <= 0) {
+ return "-";
--- End diff --
Yes, invalid value. Maybe we can remove this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Converter Started, Complete...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r150842384
--- Diff: core/src/main/resources/org/apache/spark/ui/static/utils.js ---
@@ -46,3 +46,25 @@ function formatBytes(bytes, type) {
var i = Math.floor(Math.log(bytes) / Math.log(k));
return parseFloat((bytes / Math.pow(k, i)).toFixed(dm)) + ' ' + sizes[i];
}
+
+function padZeroes(num) {
+ return ("0" + num).slice(-2);
--- End diff --
`num.toString().padStart(2, "0")` cause [org.apache.spark.deploy.history.HistoryServerSuite](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83813/testReport/) test failed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][CORE][WEB-UI] Support configure history se...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83550/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][CORE][WEB-UI] Support configure history se...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83601 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83601/testReport)** for PR 19640 at commit [`d9994ea`](https://github.com/apache/spark/commit/d9994ea88e880b86660cfb382ce57c5bbd630811).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83900 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83900/testReport)** for PR 19640 at commit [`40ec67e`](https://github.com/apache/spark/commit/40ec67e01de09bb7215aa1736ffff6a88d03e66e).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Converter Started, Complete...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r151099589
--- Diff: core/src/main/resources/org/apache/spark/ui/static/utils.js ---
@@ -46,3 +46,25 @@ function formatBytes(bytes, type) {
var i = Math.floor(Math.log(bytes) / Math.log(k));
return parseFloat((bytes / Math.pow(k, i)).toFixed(dm)) + ' ' + sizes[i];
}
+
+function padZeroes(num) {
+ return ("0" + num).slice(-2);
+}
+
+function formatTimeMillis(timeMillis) {
+ if (timeMillis <= 0) {
+ return "-";
+ } else {
+ var dt = new Date(timeMillis);
+ return dt.getFullYear() + "-" +
+ padZeroes(dt.getMonth() + 1) + "-" +
+ padZeroes(dt.getDate()) + " " +
+ padZeroes(dt.getHours()) + ":" +
+ padZeroes(dt.getMinutes()) + ":" +
+ padZeroes(dt.getSeconds());
+ }
+}
+
+function getTimeZone() {
+ return new Date().toString().match(/\(([A-Za-z\s].*)\)/)[1];
--- End diff --
did you have proxy on your chrome? It works fine at my Chrome.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][CORE][WEB-UI] Support configure history se...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Replace GMT with history server si...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][CORE][WEB-UI] Support configure history se...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83601/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][CORE][WEB-UI] Support configure history se...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19640
I think it makes sense, but the implementation is too hacky. We should extract the time epoch and convert it to timestamp string with local timezone.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83848 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83848/testReport)** for PR 19640 at commit [`4a78965`](https://github.com/apache/spark/commit/4a78965c22f11fbda7c9ba843ee266048bf6d319).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19640
how about `Client local time zone`? any better ideas?
BTW the `last updated` timestamp string at the beginning, which time zone it is?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Replace GMT with history server si...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83383 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83383/testReport)** for PR 19640 at commit [`c7339c8`](https://github.com/apache/spark/commit/c7339c8b01ffca21874fa837d5139879db01ee05).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Converter Started, Complete...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r151033625
--- Diff: core/src/main/resources/org/apache/spark/ui/static/utils.js ---
@@ -46,3 +46,25 @@ function formatBytes(bytes, type) {
var i = Math.floor(Math.log(bytes) / Math.log(k));
return parseFloat((bytes / Math.pow(k, i)).toFixed(dm)) + ' ' + sizes[i];
}
+
+function padZeroes(num) {
+ return ("0" + num).slice(-2);
--- End diff --
[TagNameQuery("a") ](https://github.com/apache/spark/blob/4a78965c22f11fbda7c9ba843ee266048bf6d319/core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala#L349) gets result from [WebBrowser](https://github.com/apache/spark/blob/4a78965c22f11fbda7c9ba843ee266048bf6d319/core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala#L43), This browser doesn't support this function.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Replace GMT with history server si...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83385 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83385/testReport)** for PR 19640 at commit [`c7339c8`](https://github.com/apache/spark/commit/c7339c8b01ffca21874fa837d5139879db01ee05).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Replace GMT with history server si...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/19640
@srowen I have read the discussion about this issue by https://github.com/apache/spark/pull/15803. But users feel that the current readability is still bad.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][CORE][WEB-UI] Support configure history se...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19640
I'm not a fan of this change; this seems like it should be done client-side, so that the browser shows timestamps in its own time zone, and the server should only know about UTC. The API probably should be left alone - especially because with this change it becomes a little confusing, since you have a timestamp in whatever is the configured server tz, and the raw value which is in UTC.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Replace GMT with history server si...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19640
@wangyum this was a WontFix. See linked JIRAs for some of the discussion and implications.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83813/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83868 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83868/testReport)** for PR 19640 at commit [`4a78965`](https://github.com/apache/spark/commit/4a78965c22f11fbda7c9ba843ee266048bf6d319).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][CORE][WEB-UI] Support configure history se...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/19640
@cloud-fan For the UI part, how about this PR: https://github.com/apache/spark/pull/14577
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Replace GMT with history se...
Posted by dbolshak <gi...@git.apache.org>.
Github user dbolshak commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r148750407
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala ---
@@ -426,6 +426,10 @@ class SparkHadoopUtil extends Logging {
ugi.getAuthenticationMethod() == UserGroupInformation.AuthenticationMethod.PROXY
}
+ def getTimeZone: TimeZone = {
--- End diff --
I would write it like
```
def timeZone: TimeZone = TimeZone.getTimeZone(sparkConf.get("spark.history.timeZone", "GMT"))
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Converter Started, Complete...
Posted by ajbozarth <gi...@git.apache.org>.
Github user ajbozarth commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r151253170
--- Diff: core/src/main/resources/org/apache/spark/ui/static/utils.js ---
@@ -46,3 +46,31 @@ function formatBytes(bytes, type) {
var i = Math.floor(Math.log(bytes) / Math.log(k));
return parseFloat((bytes / Math.pow(k, i)).toFixed(dm)) + ' ' + sizes[i];
}
+
+function padZeroes(num) {
+ return ("0" + num).slice(-2);
+}
+
+function formatTimeMillis(timeMillis) {
+ if (timeMillis <= 0) {
+ return "-";
+ } else {
+ var dt = new Date(timeMillis);
+ return dt.getFullYear() + "-" +
+ padZeroes(dt.getMonth() + 1) + "-" +
+ padZeroes(dt.getDate()) + " " +
+ padZeroes(dt.getHours()) + ":" +
+ padZeroes(dt.getMinutes()) + ":" +
+ padZeroes(dt.getSeconds());
+ }
+}
+
+function getTimeZone() {
+ try {
--- End diff --
Spark does not have a list of supported browsers, from my experience most of us just test new UI changes on whatever browsers we have (In my case the latest Safari, Chrome and Firefox ESR). Though I'd like to think we don't have any IE users, we can't make that assumption while IE 11 is still supported by MS.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Converter Started, Complete...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r150841579
--- Diff: core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala ---
@@ -352,7 +352,7 @@ class HistoryServerSuite extends SparkFunSuite with BeforeAndAfter with Matchers
.map(_.get)
.filter(_.startsWith(url)).toList
- // there are atleast some URL links that were generated via javascript,
+ // there are at least some URL links that were generated via javascript,
--- End diff --
Fix a typo
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/19640
It looks like this:
<img width="1106" alt="new" src="https://user-images.githubusercontent.com/5399861/32779430-be47bac8-c978-11e7-97d1-fd3e3db9166f.png">
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19640
The timezone is decided by the client(browser), which means it will be same for all timestamp strings in this browser, maybe put it in the title is more concise?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83868 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83868/testReport)** for PR 19640 at commit [`4a78965`](https://github.com/apache/spark/commit/4a78965c22f11fbda7c9ba843ee266048bf6d319).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Converter Started, Complete...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r150538938
--- Diff: core/src/main/resources/org/apache/spark/ui/static/historypage.js ---
@@ -38,8 +38,17 @@ function makeIdNumeric(id) {
}
function formatDate(date) {
- if (date <= 0) return "-";
- else return date.split(".")[0].replace("T", " ");
+ if (date <= 0) {
+ return "-";
+ } else {
+ var dt = new Date(date);
+ return dt.getFullYear() + "-" +
+ ("0" + (dt.getMonth() + 1)).slice(-2) + "-" +
--- End diff --
How about this:
```javascript
function formatDate(date) {
if (date <= 0) {
return "-";
} else {
var dt = new Date(date);
return dt.getFullYear() + "-" +
(dt.getMonth() + 1).toString().padStart(2, "0") + "-" +
(dt.getDate()).toString().padStart(2, "0") + " " +
(dt.getHours()).toString().padStart(2, "0") + ":" +
(dt.getMinutes()).toString().padStart(2, "0") + ":" +
(dt.getSeconds()).toString().padStart(2, "0");
}
}
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Converter Started, Complete...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r151186737
--- Diff: core/src/main/resources/org/apache/spark/ui/static/utils.js ---
@@ -46,3 +46,29 @@ function formatBytes(bytes, type) {
var i = Math.floor(Math.log(bytes) / Math.log(k));
return parseFloat((bytes / Math.pow(k, i)).toFixed(dm)) + ' ' + sizes[i];
}
+
+function padZeroes(num) {
+ return ("0" + num).slice(-2);
+}
+
+function formatTimeMillis(timeMillis) {
+ if (timeMillis <= 0) {
+ return "-";
+ } else {
+ var dt = new Date(timeMillis);
+ return dt.getFullYear() + "-" +
+ padZeroes(dt.getMonth() + 1) + "-" +
+ padZeroes(dt.getDate()) + " " +
+ padZeroes(dt.getHours()) + ":" +
+ padZeroes(dt.getMinutes()) + ":" +
+ padZeroes(dt.getSeconds());
+ }
+}
+
+function getTimeZone() {
+ try {
+ return Intl.DateTimeFormat().resolvedOptions().timeZone;
+ } catch(ex) {
+ return new Date().toString().match(/\((.*)\)/)[1];
--- End diff --
if you really want to keep this code, please add comment to explain this regex.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83813 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83813/testReport)** for PR 19640 at commit [`9a40da0`](https://github.com/apache/spark/commit/9a40da00a80aa4cc5e1af7a4cc8a848d132c974a).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Converter Started, Complete...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r150561867
--- Diff: core/src/main/resources/org/apache/spark/ui/static/historypage.js ---
@@ -38,8 +38,17 @@ function makeIdNumeric(id) {
}
function formatDate(date) {
- if (date <= 0) return "-";
- else return date.split(".")[0].replace("T", " ");
+ if (date <= 0) {
+ return "-";
+ } else {
+ var dt = new Date(date);
+ return dt.getFullYear() + "-" +
+ ("0" + (dt.getMonth() + 1)).slice(-2) + "-" +
--- End diff --
yea much better, `.toString().padStart(2, "0")` can be a method.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83813 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83813/testReport)** for PR 19640 at commit [`9a40da0`](https://github.com/apache/spark/commit/9a40da00a80aa4cc5e1af7a4cc8a848d132c974a).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Replace GMT with history server si...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19640
This is a significant behavior change though. If anything we need to move towards GMT, not towards varying with whatever the server's timezone is.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Replace GMT with history server si...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83326 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83326/testReport)** for PR 19640 at commit [`17bddef`](https://github.com/apache/spark/commit/17bddef90069e4119576c5d5da99042c005b4a43).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Replace GMT with history server si...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/19640
@srowen We can configure time zone by`spark.history.timeZone` now.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][CORE][WEB-UI] Support configure history se...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83550 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83550/testReport)** for PR 19640 at commit [`5291d16`](https://github.com/apache/spark/commit/5291d1641c1a5dcbacd7579c11430ea791acfd56).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Replace GMT with history server si...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83326 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83326/testReport)** for PR 19640 at commit [`17bddef`](https://github.com/apache/spark/commit/17bddef90069e4119576c5d5da99042c005b4a43).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83727/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Converter Started, Complete...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r151197868
--- Diff: core/src/main/resources/org/apache/spark/ui/static/utils.js ---
@@ -46,3 +46,31 @@ function formatBytes(bytes, type) {
var i = Math.floor(Math.log(bytes) / Math.log(k));
return parseFloat((bytes / Math.pow(k, i)).toFixed(dm)) + ' ' + sizes[i];
}
+
+function padZeroes(num) {
+ return ("0" + num).slice(-2);
+}
+
+function formatTimeMillis(timeMillis) {
+ if (timeMillis <= 0) {
+ return "-";
+ } else {
+ var dt = new Date(timeMillis);
+ return dt.getFullYear() + "-" +
+ padZeroes(dt.getMonth() + 1) + "-" +
+ padZeroes(dt.getDate()) + " " +
+ padZeroes(dt.getHours()) + ":" +
+ padZeroes(dt.getMinutes()) + ":" +
+ padZeroes(dt.getSeconds());
+ }
+}
+
+function getTimeZone() {
+ try {
--- End diff --
Some old browser doesn't support this function. so I surround with try catch.
Feature | Chrome | Edge | Firefox | Internet Explorer | Opera | Safari
-- | -- | -- | -- | -- | -- | --
Basic support | 24 | 12 | 29 | 11 | 15 | 10
computed timeZone | 35 | 14 | 53 | No | 30 | 10
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DateTimeFormat/resolvedOptions
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Replace GMT with history server si...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83326/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Converter Started, Complete...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r150428853
--- Diff: core/src/main/resources/org/apache/spark/ui/static/historypage.js ---
@@ -38,8 +38,17 @@ function makeIdNumeric(id) {
}
function formatDate(date) {
- if (date <= 0) return "-";
- else return date.split(".")[0].replace("T", " ");
+ if (date <= 0) {
+ return "-";
--- End diff --
just for curious, what does a single `-` mean here? invalid value?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83727 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83727/testReport)** for PR 19640 at commit [`7b04e08`](https://github.com/apache/spark/commit/7b04e08fd431ed5ea1fe3473e24e400b4c6e8b7c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Replace GMT with history se...
Posted by dbolshak <gi...@git.apache.org>.
Github user dbolshak commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r148750999
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala ---
@@ -426,6 +426,10 @@ class SparkHadoopUtil extends Logging {
ugi.getAuthenticationMethod() == UserGroupInformation.AuthenticationMethod.PROXY
}
+ def getTimeZone: TimeZone = {
+ TimeZone.getTimeZone(sparkConf.get("spark.history.timeZone", "GMT"))
--- End diff --
It's a bit confusing using `spark.history.timeZone` property in getTimeZone method of SparkHadoopUtil.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Converter Started, Complete...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r150493195
--- Diff: core/src/main/resources/org/apache/spark/ui/static/historypage.js ---
@@ -38,8 +38,17 @@ function makeIdNumeric(id) {
}
function formatDate(date) {
- if (date <= 0) return "-";
- else return date.split(".")[0].replace("T", " ");
+ if (date <= 0) {
+ return "-";
+ } else {
+ var dt = new Date(date);
+ return dt.getFullYear() + "-" +
+ ("0" + (dt.getMonth() + 1)).slice(-2) + "-" +
--- End diff --
this looks a bit hacky, is there any way in js to print a number to 2 letters?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Converter Started, Complete...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r150869830
--- Diff: core/src/main/resources/org/apache/spark/ui/static/utils.js ---
@@ -46,3 +46,25 @@ function formatBytes(bytes, type) {
var i = Math.floor(Math.log(bytes) / Math.log(k));
return parseFloat((bytes / Math.pow(k, i)).toFixed(dm)) + ' ' + sizes[i];
}
+
+function padZeroes(num) {
+ return ("0" + num).slice(-2);
--- End diff --
what does the test use?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][CORE][WEB-UI] Support configure history se...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83480 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83480/testReport)** for PR 19640 at commit [`f36023a`](https://github.com/apache/spark/commit/f36023a976c69a7b56f4c3d09c2dde04d0b047c7).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19640
JS is not really my thing, but other have reviewed and seem ok. I'm fine with this being done client-side.
Merging to master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83900/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/19640
Generated by the `toLocaleTimeString ()` method:
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Converter Started, Complete...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19640
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][CORE][WEB-UI] Support configure history se...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83480 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83480/testReport)** for PR 19640 at commit [`f36023a`](https://github.com/apache/spark/commit/f36023a976c69a7b56f4c3d09c2dde04d0b047c7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Converter Started, Complete...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r151213417
--- Diff: core/src/main/resources/org/apache/spark/ui/static/utils.js ---
@@ -46,3 +46,31 @@ function formatBytes(bytes, type) {
var i = Math.floor(Math.log(bytes) / Math.log(k));
return parseFloat((bytes / Math.pow(k, i)).toFixed(dm)) + ' ' + sizes[i];
}
+
+function padZeroes(num) {
+ return ("0" + num).slice(-2);
+}
+
+function formatTimeMillis(timeMillis) {
+ if (timeMillis <= 0) {
+ return "-";
+ } else {
+ var dt = new Date(timeMillis);
+ return dt.getFullYear() + "-" +
+ padZeroes(dt.getMonth() + 1) + "-" +
+ padZeroes(dt.getDate()) + " " +
+ padZeroes(dt.getHours()) + ":" +
+ padZeroes(dt.getMinutes()) + ":" +
+ padZeroes(dt.getSeconds());
+ }
+}
+
+function getTimeZone() {
+ try {
--- End diff --
cc @srowen does Spark have a guarantee about which version of which browser to support?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][CORE][WEB-UI] Support configure his...
Posted by jiangxb1987 <gi...@git.apache.org>.
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r149661121
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala ---
@@ -426,6 +426,8 @@ class SparkHadoopUtil extends Logging {
ugi.getAuthenticationMethod() == UserGroupInformation.AuthenticationMethod.PROXY
}
+ def getHistoryServerTimeZone: String = sparkConf.get("spark.history.timeZone", "GMT")
--- End diff --
Please add this config to `internal/config`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][CORE][WEB-UI] Support configure history se...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83601 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83601/testReport)** for PR 19640 at commit [`d9994ea`](https://github.com/apache/spark/commit/d9994ea88e880b86660cfb382ce57c5bbd630811).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Replace GMT with history server si...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83902 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83902/testReport)** for PR 19640 at commit [`08f5e68`](https://github.com/apache/spark/commit/08f5e6808847ad9ca383dc6f78ca3d733efc00ab).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Replace GMT with history server si...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83385 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83385/testReport)** for PR 19640 at commit [`c7339c8`](https://github.com/apache/spark/commit/c7339c8b01ffca21874fa837d5139879db01ee05).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Replace GMT with history server si...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83383 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83383/testReport)** for PR 19640 at commit [`c7339c8`](https://github.com/apache/spark/commit/c7339c8b01ffca21874fa837d5139879db01ee05).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83848/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Replace GMT with history server si...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/19640
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by jiangxb1987 <gi...@git.apache.org>.
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19640
IMO we'd better have timeZone after each datetime string, that would avoid a lot of confusions.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Converter Started, Complete...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r150849659
--- Diff: core/src/main/resources/org/apache/spark/ui/static/utils.js ---
@@ -46,3 +46,25 @@ function formatBytes(bytes, type) {
var i = Math.floor(Math.log(bytes) / Math.log(k));
return parseFloat((bytes / Math.pow(k, i)).toFixed(dm)) + ' ' + sizes[i];
}
+
+function padZeroes(num) {
+ return ("0" + num).slice(-2);
--- End diff --
do you know why?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Converter Started, Complete...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r150428888
--- Diff: core/src/main/resources/org/apache/spark/ui/static/historypage.js ---
@@ -38,8 +38,17 @@ function makeIdNumeric(id) {
}
function formatDate(date) {
- if (date <= 0) return "-";
- else return date.split(".")[0].replace("T", " ");
+ if (date <= 0) {
+ return "-";
+ } else {
+ var dt = new Date(date);
+ return dt.getFullYear() + "-" +
--- End diff --
not familiar with js, does js have something like java `SimpleDateFormat`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83900 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83900/testReport)** for PR 19640 at commit [`40ec67e`](https://github.com/apache/spark/commit/40ec67e01de09bb7215aa1736ffff6a88d03e66e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Converter Started, Complete...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r150863877
--- Diff: core/src/main/resources/org/apache/spark/ui/static/utils.js ---
@@ -46,3 +46,25 @@ function formatBytes(bytes, type) {
var i = Math.floor(Math.log(bytes) / Math.log(k));
return parseFloat((bytes / Math.pow(k, i)).toFixed(dm)) + ' ' + sizes[i];
}
+
+function padZeroes(num) {
+ return ("0" + num).slice(-2);
--- End diff --
`padStart` with poor compatibility:
Feature | Chrome | Edge | Firefox | Internet Explorer | Opera | Safari
-- | -- | -- | -- | -- | -- | --
Basic support | 57 | 15 | 48 | No | 44 | 10
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/padStart
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/slice
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19640
How about we add the timezone abbreviation in the title? e.g. `started(PST)`, `completed(PST)`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][CORE][WEB-UI] Support configure history se...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83550 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83550/testReport)** for PR 19640 at commit [`5291d16`](https://github.com/apache/spark/commit/5291d1641c1a5dcbacd7579c11430ea791acfd56).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][CORE][WEB-UI] Support configure his...
Posted by dbolshak <gi...@git.apache.org>.
Github user dbolshak commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r149087915
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2742,6 +2742,11 @@ private[spark] object Utils extends Logging {
}
}
+ def getTimeZone: TimeZone = {
--- End diff --
Could you please image that this method will be used outside scope of the current issue?
What's about users who does not have spark history at all?
The name of method, the class and the package does not tell us that this method somehow related ONLY to history server, such API makes me easy to do wrong assumptions.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Replace GMT with history server si...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by ajbozarth <gi...@git.apache.org>.
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/19640
I'm still not 100% convinced this is the best change, but the implementation LGTM.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Converter Started, Complete...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r150869426
--- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala ---
@@ -56,6 +56,10 @@ private[history] class HistoryPage(parent: HistoryServer) extends WebUIPage("")
}
{
+ <p>Client local time zone: <span id="time-zone"></span></p>
--- End diff --
any more feedback on the naming?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/19640
How about this?
<img width="1226" alt="timezone" src="https://user-images.githubusercontent.com/5399861/32773266-8f9c1ce2-c963-11e7-8b9d-dba785f71772.png">
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Replace GMT with history server si...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Replace GMT with history server si...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83385/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][CORE][WEB-UI] Support configure history se...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][WEB-UI] Converter Started, Complete...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r150430610
--- Diff: core/src/main/resources/org/apache/spark/ui/static/historypage.js ---
@@ -38,8 +38,17 @@ function makeIdNumeric(id) {
}
function formatDate(date) {
- if (date <= 0) return "-";
- else return date.split(".")[0].replace("T", " ");
+ if (date <= 0) {
+ return "-";
+ } else {
+ var dt = new Date(date);
+ return dt.getFullYear() + "-" +
--- End diff --
Native Javascript does not support.
https://www.w3schools.com/js/js_date_formats.asp
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19640: [SPARK-16986][CORE][WEB-UI] Support configure his...
Posted by jiangxb1987 <gi...@git.apache.org>.
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r149365816
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2742,6 +2742,11 @@ private[spark] object Utils extends Logging {
}
}
+ def getTimeZone: TimeZone = {
+ val sparkConf = new SparkConf(false).loadFromSystemProperties(true)
--- End diff --
Can we make SparkConf as a input param instead of create a new instance for every function call?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Converter Started, Completed and L...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/19640
retest this please.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][CORE][WEB-UI] Support configure history se...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83727 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83727/testReport)** for PR 19640 at commit [`7b04e08`](https://github.com/apache/spark/commit/7b04e08fd431ed5ea1fe3473e24e400b4c6e8b7c).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19640: [SPARK-16986][WEB-UI] Replace GMT with history server si...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83383/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org